Re: delete PCI_ from PCI-X and PCIe register definitions in pcireg.h

[SAITOH Masanobu <msaitoh%execsw.org@localhost>]

(2013/04/20 0:50), SAITOH Masanobu wrote:
> Hi.
> 
> The following lines are example of PCI-X and PCIe capability
> register definitions in pcireg.h:
> 
>> #define PCI_PCIX_STATUS                 0x04
>> #define PCI_PCIX_STATUS_FN_MASK         0x00000007
>> #define PCI_PCIX_STATUS_DEV_MASK        0x000000f8
>> #define PCI_PCIX_STATUS_BUS_MASK        0x0000ff00
>> #define PCI_PCIX_STATUS_64BIT           0x00010000
>> #define PCI_PCIX_STATUS_133             0x00020000
>> #define PCI_PCIX_STATUS_SPLDISC         0x00040000
>> #define PCI_PCIX_STATUS_SPLUNEX         0x00080000
>> #define PCI_PCIX_STATUS_DEVCPLX         0x00100000
>> #define PCI_PCIX_STATUS_MAXB_MASK       0x00600000
>> #define PCI_PCIX_STATUS_MAXB_SHIFT      21
>> #define         PCI_PCIX_STATUS_MAXB_512        0x00000000
>> #define         PCI_PCIX_STATUS_MAXB_1024       0x00200000
>> #define         PCI_PCIX_STATUS_MAXB_2048       0x00400000
>> #define         PCI_PCIX_STATUS_MAXB_4096       0x00600000
> 
>> #define PCI_PCIE_LCSR   0x10    /* Link Control & Status Register */
>> #define PCI_PCIE_LCSR_ASPM_L0S  __BIT(0)
>> #define PCI_PCIE_LCSR_ASPM_L1   __BIT(1)
>> #define PCI_PCIE_LCSR_RCB       __BIT(3)
>> #define PCI_PCIE_LCSR_LINK_DIS  __BIT(4)
>> #define PCI_PCIE_LCSR_RETRAIN   __BIT(5)
>> #define PCI_PCIE_LCSR_COMCLKCFG __BIT(6)
>> #define PCI_PCIE_LCSR_EXTNDSYNC __BIT(7)
>> #define PCI_PCIE_LCSR_ENCLKPM   __BIT(8)
>> #define PCI_PCIE_LCSR_HAWD      __BIT(9)
>> #define PCI_PCIE_LCSR_LBMIE     __BIT(10)
>> #define PCI_PCIE_LCSR_LABIE     __BIT(11)
>> #define PCI_PCIE_LCSR_LINKSPEED __BITS(19,16)
>> #define PCI_PCIE_LCSR_NLW       __BITS(25,20)
>> #define PCI_PCIE_LCSR_LINKTRAIN_ERR     __BIT(26)
>> #define PCI_PCIE_LCSR_LINKTRAIN __BIT(27)
> 
>  I think "PCI[XE]_" is better than "PCI_PCI[XE]_" to reduce
> the length or to rename to be more useful name.
> 
>  Any objection?

Done.

-- 
-----------------------------------------------
                SAITOH Masanobu (msaitoh%execsw.org@localhost
                                 msaitoh%netbsd.org@localhost)