Re: IPFilter issue in -current

[christos%astron.com@localhost (Christos Zoulas)]

In article <684A3848-3E2B-43E9-BB3D-E96DA6F520CD%avernus.com@localhost>,
Geoff Adams  <gadams+netbsd%avernus.com@localhost> wrote:
>-=-=-=-=-=-
>
>On Nov 27, 2012, at 11:11 PM PST, I wrote:
>
>> I'll try changing the locking so that ipf_ht_node_del is called within
>the hold on is->is_lock.
>
>Unfortunately, the obvious patch (attached) doesn't seem to solve the
>problem. It might make it slightly better, but I still get the
>occasional hang, apparently within the red-black tree code. A frequent
>culprit has been RBI_SEARCH.
>
>I wonder if the RBI_* macros are just not thread-safe even when
>operating on different keys.

They don't seem to be. I would convert the code to use our <sys/rbtree.h>
implementation, and lock all operations. Now I am wondering why you are
the only one seeing this.

christos