Re: various new build breakage (mostly due to gcc-4.5)

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Wed, Aug 17, 2011 at 07:31:45AM +0900, Ryo ONODERA wrote:
> Hi,
> 
> From: Thomas Klausner <wiz%NetBSD.org@localhost>, Date: Sun, 14 Aug 2011 
> 21:19:10 +0200
> 
> > Hi!
> > 
> > I've upgraded my NetBSD-5.99.55/amd64 to one with gcc-4.5. I see the
> > following new breakage to my previous 5.99.55 snapshot. I'd appreciate
> > suggestions for fixes.
> > 
> > boost issues in textproc/FlightCrew, wip/Sigil, graphics/exiv2-organize:
> > In file included from 
> > /scratch/textproc/FlightCrew/work/.buildlink/include/boost/filesystem.hpp:36:0,
> >                  from 
> > /scratch/textproc/FlightCrew/work/FlightCrew-0.7.1-Code/src/zipios/../FlightCrew/Misc/BoostFilesystemUse.h:28,
> >                  from 
> > /scratch/textproc/FlightCrew/work/FlightCrew-0.7.1-Code/src/zipios/src/dircoll.cpp:10:
> > /scratch/textproc/FlightCrew/work/.buildlink/include/boost/filesystem/v3/operations.hpp:126:3:
> >  warning: scoped enums only available with -std=c++0x or -std=gnu++0x
> > /scratch/textproc/FlightCrew/work/.buildlink/include/boost/filesystem/v3/operations.hpp:
> >  In function 'void boost::filesystem3::copy_file(const 
> > boost::filesystem3::path&, const boost::filesystem3::path&)':
> > /scratch/textproc/FlightCrew/work/.buildlink/include/boost/filesystem/v3/operations.hpp:303:69:
> >  error: 'copy_option' is not a class or namespace
> > /scratch/textproc/FlightCrew/work/.buildlink/include/boost/filesystem/v3/operations.hpp:
> >  In function 'void boost::filesystem3::copy_file(const 
> > boost::filesystem3::path&, const boost::filesystem3::path&, 
> > boost::system::error_code&)':
> > /scratch/textproc/FlightCrew/work/.buildlink/include/boost/filesystem/v3/operations.hpp:310:69:
> >  error: 'copy_option' is not a class or namespace
> 
> This error is fixed with attached patch.

Thanks. I tried to put it in the pkgsrc Makefile where it belongs
(because it's compiler-dependent), but did not manage to find a
working version.

Does anyone have an idea how to get them accepted?
(non-working patch attached)
 Thomas

P.S.: Ryo, what is the "fixing" step in the Makefile for? For me it
just seems to change a comment and I don't see why that comment could
break anything.

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/textproc/FlightCrew/Makefile,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 Makefile
--- Makefile    29 Jul 2011 19:32:18 -0000      1.1.1.1
+++ Makefile    17 Aug 2011 08:57:51 -0000
@@ -28,6 +28,14 @@
 SUBST_SED.fix-damaged+=                -e "2,2s/^/\//" # commented-out
 SUBST_SED.fix-damaged+=                -e "1,1d" # deleted
 
+.include "../../mk/compiler.mk"
+.if !empty(CC_VERSION:Mgcc-4.5*)
+CXXFLAGS+=     -std=c++0x
+CMAKE_ARGS+=   -DCMAKE_CXX_FLAGS=${CXXFLAGS:Q}
+CMAKE_ARGS+=   -DCMAKE_C_FLAGS=${CXXFLAGS:Q}
+CMAKE_ARGS+=   -DCMAKE_CPP_FLAGS=${CXXFLAGS:Q}
+.endif
+
 .include "../../devel/googletest/buildlink3.mk"
 .include "../../devel/gmock/buildlink3.mk"
 .include "../../textproc/xerces-c/buildlink3.mk"