Re: getaddrinfo tests

[Takahiro HAYASHI <hash%abox3.so-net.ne.jp@localhost>]

hello,

On Thu, 3 Feb 2011 17:07:06 +0200
Antti Kantee <pooka%cs.hut.fi@localhost> wrote:

> hi,
> 
> Between 2011.01.31:23.07.16 and 2011.02.01:06.46.47 the
> lib/libc/net/getaddrinfo tests started failing on i386:
> 
> http://www.gson.org/netbsd/bugs/build/build/2011.02.02.12.26.42/test.html#lib_libc_net_getaddrinfo_t_getaddrinfo_empty_hostname
> http://www.gson.org/netbsd/bugs/build/build/2011.02.02.12.26.42/test.html#lib_libc_net_getaddrinfo_t_getaddrinfo_scopeaddr
> 
> I'm not sure what exactly caused the different behaviour, or why we don't
> see this on amd64.
> 
> Can someone who knows what should be going on have a look?
> 
> -- 
> 舁\xE7
karot toivorikkauttas, kyl r舩ei ja lumpui piisaa

i think lib/libc/net/getifaddrs.c needs fixed.
should use RT_ROUNDUP macro in <net/route.h>?

Index: lib/libc/net/getifaddrs.c
===================================================================
RCS file: /cvsroot/src/lib/libc/net/getifaddrs.c,v
retrieving revision 1.13
diff -U 2 -r1.13 getifaddrs.c
--- lib/libc/net/getifaddrs.c   5 Nov 2010 16:23:56 -0000       1.13
+++ lib/libc/net/getifaddrs.c   3 Feb 2011 22:16:04 -0000
@@ -59,5 +59,5 @@
 #endif
 
-#define        SALIGN  (sizeof(long) - 1)
+#define        SALIGN  (sizeof(uint64_t) - 1)
 #define        SA_RLEN(sa)     ((sa)->sa_len ? (((sa)->sa_len + SALIGN) & 
~SALIGN) : (SALIGN + 1))
 

-- 
Takahiro HAYASHI <hash at abox3 dot so-net dot ne dot jp>