Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: unable to build i386 ALL kernel, errors in smbus_acpi.c (ACPI_SMBUS_COMPONENT undeclared)

No worries, Greg!

It seems that I did my test build in my private tree rather than my official tree. And when transferring the changes in smbus_acpi.c from one tree to the other, I put those two lines in the wrong place. The
macros were invoked before required constants were #included.

I apologize for breaking to build, and I thank Jukka Ruohonen for moving those two critical lines to the right place.

On Thu, 4 Mar 2010, Greg A. Woods wrote:

At Thu, 4 Mar 2010 12:06:55 -0800 (PST), Paul Goyette 
<> wrote:
Subject: Re: unable to build i386 ALL kernel, errors in smbus_acpi.c 

The checked-in fixes were compiled using ' -m i386 kernel=ALL'

(The checked-in fixes were sligfhtly different from what I sent via

If there are more options required, please let me know and I will verify

Sorry I should have posted this minor cleanup and extension of ALL too.

I had forgotten that besides consolidating some *VERBOSE and *DEBUG
options into their respective groups, some also were turned on as well.
It's been such a long time since I made these fixes.

I didn't think the "+iic* at acpismbus?" addition would add more code,
but perhaps it does?

The key ones here were probably these three:

        options ACPI_DEBUG
        options ACPI_DEBUG_ALLOC
        options ACPI_MUTEX_DEBUG

I'm not sure why they were left commented out.  I'm not sure when I last
built in -current with these changes -- I guess it must have been before
the last major ACPI code update.

Index: sys/arch/i386/conf/ALL
RCS file: /cvs/master/m-NetBSD/main/src/sys/arch/i386/conf/ALL,v
retrieving revision 1.245
diff -u -r1.245 ALL
--- sys/arch/i386/conf/ALL      3 Mar 2010 06:57:53 -0000       1.245
+++ sys/arch/i386/conf/ALL      4 Mar 2010 21:00:25 -0000
@@ -1,3 +1,5 @@
+# -*-sh-*-
# $NetBSD: ALL,v 1.245 2010/03/03 06:57:53 jruoho Exp $
# From NetBSD: GENERIC,v 1.787 2006/10/01 18:37:54 bouyer Exp
@@ -217,7 +219,7 @@
options         IPSEC           # IP security
options         IPSEC_ESP       # IP security (encryption part; define w/IPSEC)
options         IPSEC_NAT_T     # IPsec NAT traversal (NAT-T)
-#options       IPSEC_DEBUG     # debug for IP security
+#below#options         IPSEC_DEBUG     # debug for IP security
options         MROUTING        # IP multicast routing
options         PIM             # Protocol Independent Multicast
options         ISO,TPIP        # OSI
@@ -230,9 +232,11 @@
options         IPFILTER_LOG    # ipmon(8) log support
options         IPFILTER_LOOKUP # ippool(8) support
options         IPFILTER_DEFAULT_BLOCK  # block all packets by default
-options        TCP_DEBUG       # Record last TCP_NDEBUG packets with SO_DEBUG
+#below#options         TCP_DEBUG       # Record last TCP_NDEBUG packets with 
options         TCP_SIGNATURE   # RFC 2385 support, used with BGP

+options        NMBCLUSTERS=1024 # mbuf clusters (MCLBYTES, 2k(? 4K!), in size)
options         ALTQ            # Manipulate network interfaces' output queues
options         ALTQ_BLUE       # Stochastic Fair Blue
options         ALTQ_CBQ        # Class-Based Queueing
@@ -245,6 +249,7 @@
options         ALTQ_RED        # Random Early Detection
options         ALTQ_RIO        # RED with IN/OUT
options         ALTQ_WFQ        # Weighted Fair Queueing
+#below#options         ALTQ_DEBUG      # for debugging

# These options enable verbose messages for several subsystems.
# Warning, these may compile large string tables into the kernel!
@@ -252,13 +257,16 @@
options         EISAVERBOSE     # verbose EISA device autoconfig messages
options         MIIVERBOSE      # verbose PHY autoconfig messages
options         PCIVERBOSE      # verbose PCI device autoconfig messages
+options        PCIBIOSVERBOSE          # PCI BIOS verbose info
options         PCI_CONFIG_DUMP # verbosely dump PCI config space
options         PCMCIAVERBOSE   # verbose PCMCIA configuration messages
options         SCSIVERBOSE     # human readable SCSI error messages
options         USBVERBOSE      # verbose USB device autoconfig messages
options         PNPBIOSVERBOSE  # verbose PnP BIOS messages
-#options       PNPBIOSDEBUG    # more fulsome PnP BIOS debugging messages
+#below#options         PNPBIOSDEBUG    # more fulsome PnP BIOS debugging 
options         MCAVERBOSE      # verbose MCA device autoconfig messages
+options        MPVERBOSE       # verbose MULTIPROCESSOR messages
options         I2C_SCAN        # Scan i2c bus for responses

@@ -328,6 +336,7 @@
# Doesn't do anything yet.
p64h2apic* at pci? dev? function?       # P64H2 IOxAPIC

+# XXX use ACPI apm emulation below...
#apm0   at mainbus0                     # Advanced power management

# Tuning for power management, see apm(4) for more details.
@@ -370,6 +379,7 @@
# XXX "native" i2c controller.  Otherwise you'll have two accessors to
# XXX the same bus, and bad things (tm) will happen!
acpismbus*      at acpi?                # ACPI SMBus CMI (experimental)
+iic*           at acpismbus?
acpitz*         at acpi?                # ACPI Thermal Zone
acpiwmi*        at acpi?                # ACPI WMI Mapper

@@ -442,7 +452,7 @@

# Configure PCI using BIOS information
options         PCIBIOS                 # PCI BIOS support
-options        PCIBIOSVERBOSE          # PCI BIOS verbose info
+#above#options         PCIBIOSVERBOSE          # PCI BIOS verbose info
options         PCIBIOS_IRQS_HINT=0x0a00 # PCI interrupts hint. IRQ 9 or 11
options         PCIBIOS_INTR_GUESS      # see pcibios(4)
options         PCIBIOS_LIBRETTO_FIXUP  # this code makes the Toshiba Libretto
@@ -451,7 +461,7 @@
options         PCIBIOS_SHARP_MM20_FIXUP # this code makes the Sharp MM 20
                                        # work, but should not be enabled
                                        # on anything else.
-#options       PCIINTR_DEBUG           # super-verbose PCI interrupt fixup
+#below#options         PCIINTR_DEBUG           # super-verbose PCI interrupt 

# PCI fixups, for both PCIBIOS and ACPI
options         PCI_ADDR_FIXUP          # fixup PCI I/O addresses
@@ -908,7 +918,7 @@

# ATA (IDE) bus support
atabus* at ata?
-options        ATADEBUG
+#below#options         ATADEBUG

# IDE drives
# Flags are used only with controllers that support DMA operations
@@ -1751,6 +1761,11 @@
pseudo-device   ippp            2 # synchronous PPP over ISDN

+# the following list of all *DEBUG* options includes some that are
+# (now) commented out above
+# XXX there should be some similar comprehensive list of *VERBOSE* options
options A9PCIC_DEBUG
options AAC_DEBUG
@@ -1759,16 +1774,16 @@
options AC97_IO_DEBUG
# ACPI_DEBUG_ALLOC can not be used with ACPI
# kernel modules. It requires also ACPI_DEBUG.
-#options ACPI_DEBUG
+options ACPI_DEBUG

options ADB_DEBUG
options ADM1030_DEBUG
options ADT7467_DEBUG
@@ -1791,6 +1806,7 @@
options ARGO_DEBUG
options ARP_DEBUG
options ASC_DEBUG
+options        ATADEBUG
options ATA_DEBUG
@@ -2234,6 +2250,7 @@
options TC5165DEBUG
+options TCP_DEBUG

                                                Greg A. Woods
                                                Planix, Inc.

<>       +1 416 218 0099

|   Paul Goyette   | PGP DSS Key fingerprint: |  E-mail addresses:      |
| Customer Service | FA29 0E3B 35AF E8AE 6651 |  paul at   |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at |
| Kernel Developer |                          | pgoyette at  |

Home | Main Index | Thread Index | Old Index