Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: recent -current usr.bin/make changes break pkgsrc again

On Tue, Jan 20, 2009 at 01:20:12PM +0000, David Holland wrote:
> On Sun, Jan 18, 2009 at 01:04:41PM +0000, David Laight wrote:
>  > Plausibly all of defined(), make(), exists(), target() and command()
>  > should just return 'false'.
> Nah, those should be errors.

Quite possibly, but not historically :-(
I think the old code backed up the input parser by the number of
characters in 'defined' (etc) then applied the default function.
However the argument parser (for .if) doesn't count () so gets
a mismatch of the end of the name...

I also suspect that:
    .if exists(${FC_PATH})
first got checked as:
    .if exists()
Then as (backing up 6 bytes):
    .ifdef _PATH})

And hence a likely 'false' - but I still don't quite see what
removed the ')'.

make needs a command line flag to report 'dubious syntax' errors.


David Laight:

Home | Main Index | Thread Index | Old Index