I got pinged about my PR and went to look at this again. I had intended to clean up my original fix based on suggestions from dsl (I think, mail is expired), but I see that Joerg has updated to the OpenBSD/Dragonfly version. Does anyone know if the problem I found (silent truncation when /tmp is too small) exists in the new version? I looked at the sources, and don't see that ofp is checked with ferror after fputs in apply_hunk. So perhaps this just needs an if (ferror(ofp)) lose() in the right place. I will leave the PR open until we're sure the new version is ok.
Attachment:
pgp6YIq77HBAS.pgp
Description: PGP signature