Re: veriexecctl(8) segfaults when no argument is given

[Brett Lymn <blymn%baesystems.com.au@localhost>]

On Mon, Sep 08, 2008 at 11:07:31PM +0930, Brett Lymn wrote:
> On Mon, Sep 08, 2008 at 04:09:46PM +0300, Stathis Kamperis wrote:
> > 
> > On the other hand, if I compile a kernel with your patch + LOCKDEBUG,
> > when I try to startX, I get a panic and here is the associated
> > backtrace:
> > 
> 
> Ah - It looks like we bail out of veriexec_file_verify() without
> setting vfep to something.  Try this (untested) patch:
> 

bah... that had a possible NULL dereference.  This one should be
better:

Index: kern_verifiedexec.c
===================================================================
RCS file: /cvsroot/src/sys/kern/kern_verifiedexec.c,v
retrieving revision 1.109
diff -u -r1.109 kern_verifiedexec.c
--- kern_verifiedexec.c 20 Jul 2008 08:50:20 -0000      1.109
+++ kern_verifiedexec.c 8 Sep 2008 15:26:53 -0000
@@ -585,6 +585,9 @@
 #define VFE_NEEDS_EVAL(vfe) ((vfe->status == FINGERPRINT_NOTEVAL) || \
                             (vfe->type & VERIEXEC_UNTRUSTED))
 
+       if (vfep != NULL)
+               *vfep = NULL;
+
        if (vp->v_type != VREG)
                return (0);
 

-- 
Brett Lymn
"Warning:
The information contained in this email and any attached files is
confidential to BAE Systems Australia. If you are not the intended
recipient, any use, disclosure or copying of this email or any
attachments is expressly prohibited.  If you have received this email
in error, please notify us immediately. VIRUS: Every care has been
taken to ensure this email and its attachments are virus free,
however, any loss or damage incurred in using this email is not the
sender's responsibility.  It is your responsibility to ensure virus
checks are completed before installing any data sent in this email to
your computer."