Re: Is setitimer broken under current?

[Sverre Froyen <sverre%viewmark.com@localhost>]

On Thursday 07 August 2008, Sverre Froyen wrote:
>
> The problem is introduced by the commit:
>
> http://mail-index.netbsd.org/source-changes/2008/07/15/msg207834.html
>
> kernels before this commit are OK, those after have a broken setitimer.

The code in dogetitimer doesn't look quite right.  The attached patch seems to 
help.

Sverre

Index: sys/kern/kern_time.c
===================================================================
RCS file: /cvsroot/src/sys/kern/kern_time.c,v
retrieving revision 1.150
diff -u -r1.150 kern_time.c
--- sys/kern/kern_time.c        15 Jul 2008 16:18:08 -0000      1.150
+++ sys/kern/kern_time.c        8 Aug 2008 15:36:35 -0000
@@ -1006,9 +1006,9 @@
                timerclear(&itvp->it_value);
                timerclear(&itvp->it_interval);
        } else {
-               TIMEVAL_TO_TIMESPEC(&itvp->it_value, &its.it_value);
-               TIMEVAL_TO_TIMESPEC(&itvp->it_interval, &its.it_interval);
                timer_gettime(pt, &its);
+               TIMESPEC_TO_TIMEVAL(&itvp->it_value, &its.it_value);
+               TIMESPEC_TO_TIMEVAL(&itvp->it_interval, &its.it_interval);
        }
        mutex_spin_exit(&timer_lock);