Re: heads up RE autoconf C23 vs legacy code

[Greg Troxel <gdt%lexort.com@localhost>]

Tobias Nygren <tnn%NetBSD.org@localhost> writes:

> I found a somewhat reasonable workaround that does not require a patch:
>
> CONFIGURE_ENV+=		ac_cv_prog_cc_c23=no
>
> I will commit that unless there are better ideas.
> The obvious drawback is we will have to add ac_cv_prog_cc_c29=no as well
> a few years down the road.

How about the following?  With this and GCC_REQD=14, scmcvs built for
me.




Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/devel/scmcvs/Makefile,v
retrieving revision 1.23
diff -u -p -r1.23 Makefile
--- Makefile	29 Apr 2025 09:10:51 -0000	1.23
+++ Makefile	2 Jul 2026 22:11:34 -0000
@@ -11,7 +11,9 @@ HOMEPAGE=	https://cvs.nongnu.org/
 COMMENT=	Concurrent Versions System
 LICENSE=	gnu-gpl-v2
 
-USE_TOOLS+=		makeinfo autoconf
+# autoconf 2.73 AC_PROG_CC attempts to set --std=c23, which cvs does not support.
+USE_TOOLS+=		 autoconf269
+USE_TOOLS+=		makeinfo
 GNU_CONFIGURE=		yes
 CONFIGURE_ARGS+=	--with-external-zlib
 CONFIGURE_ARGS+=	--with-rsh=ssh