Re: Overhauling lang/pear

[Takahiro Kambe <taca%NetBSD.org@localhost>]

Hi,

In message <aElxb-1SlgPFVaU2%pkgsrc.org@localhost>
	on Wed, 11 Jun 2025 13:07:11 +0100,
	Jonathan Perkin <jperkin%pkgsrc.org@localhost> wrote:
> As nobody else seemed interested in fixing this despite it being the
> top breakage for months, I looked into it, and did not like what I
> saw!  I can now understand why :) This has to be some of the most
> packaging hostile code I've ever seen.
> 
> I've completely overhauled it so that now it doesn't (at least as far
> as I can see) try to access the network during the
> potentially-privileged install phase (!!), has fully-documented
> patches, uses all pristine upstream sources, and actually works.
> 
> I have never until this point used pear though, so I would appreciate
> review.  The changes are here:
> 
>   https://github.com/TritonDataCenter/pkgsrc/commit/c85b955e68c80d27764e8b15d6c942ca3b7178f2
Great.

I might miss something, I got error.

% make
(OK!)
% make stage-install
=> Bootstrap dependency digest>=20211023: found digest-20220214
===> Checking for vulnerabilities in php83-pear-1.10.16nb3
===> Installing for php83-pear-1.10.16nb3
=> Generating pre-install file lists
=> Creating installation directories
cd /data/work/lang/pear/work.edge/pearweb_phars-1.10.24 &&  /usr/bin/env PHP_PEAR_PHP_BIN=/usr/pkg/bin/php83 DESTDIR=/data/work/lang/pear/work.edge/.destdir /usr/pkg/bin/php83 go-pear.phar

Below is a suggested file layout for your new PEAR installation.  To
change individual locations, type the number in front of the
directory.  Type 'all' to change all of them or simply press Enter to
accept these locations.

 1. Installation base ($prefix)                   : /usr/pkg
 2. Temporary directory for processing            : /tmp/pear/install
 3. Temporary directory for downloads             : /tmp/pear/install
 4. Binaries directory                            : /usr/pkg/bin
 5. PHP code directory ($php_dir)                 : /usr/pkg/lib/php/8.3
 6. Documentation directory                       : /usr/pkg/lib/php/8.3/doc
 7. Data directory                                : /usr/pkg/lib/php/8.3/data
 8. User-modifiable configuration files directory : /usr/pkg/lib/php/8.3/cfg
 9. Public Web Files directory                    : /usr/pkg/lib/php/8.3/www
10. System manual pages directory                 : /usr/pkg/man
11. Tests directory                               : /usr/pkg/lib/php/8.3/test
12. Name of configuration file                    : /data/work/lang/pear/work.edge/pearweb_phars-1.10.24/pear.conf

1-12, 'all' or Enter to continue: Unable to create User-modifiable configuration files directory /usr/pkg/lib/php/8.3/cfg.
Run this script as root or pick another location.
/usr/bin/install -c -o taca -g taca -m 644 /data/work/lang/pear/work.edge/pearweb_phars-1.10.24/pear.conf  /data/work/lang/pear/work.edge/.destdir/usr/pkg/share/examples/php/8.3/pear.conf
install: /data/work/lang/pear/work.edge/pearweb_phars-1.10.24/pear.conf: stat: No such file or directory
*** Error code 1

Stop.
make[1]: stopped in /data/netbsd/pkgsrc/lang/pear
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/lang/pear


-- 
Takahiro Kambe <taca%NetBSD.org@localhost> / <taca%back-street.net@localhost>