tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Overhauling lang/pear



As nobody else seemed interested in fixing this despite it being the top breakage for months, I looked into it, and did not like what I saw! I can now understand why :) This has to be some of the most packaging hostile code I've ever seen.

I've completely overhauled it so that now it doesn't (at least as far as I can see) try to access the network during the potentially-privileged install phase (!!), has fully-documented patches, uses all pristine upstream sources, and actually works.

I have never until this point used pear though, so I would appreciate review. The changes are here:

  https://github.com/TritonDataCenter/pkgsrc/commit/c85b955e68c80d27764e8b15d6c942ca3b7178f2

As mentioned in the commit log I've compared diffs for all files to the previous version and the only changes appear to be due to using a newer installer so there are some extra entries (e.g. www_dir) in pear.conf.

The one section I haven't ported over is the registry patch, which means that .depdb and .depdblock are removed from the PLIST, but will be generated on the first run of the pear command as far as I can tell.

These files, along with some others like the channel files, are modified when running pear itself, which completely breaks "pkg_admin check", for example:

  $ pear56 channel-update pear.php.net
  Updating channel "pear.php.net"
  Update of Channel "pear.php.net" succeeded

  $ pkg_admin check
  /opt/pkg/lib/php/5.6/.channels/pear.php.net.reg fails MD5 checksum

It would be better, long term, if these files were to go in VARBASE, but at least from a cursory glance there doesn't appear to be an official option to configure this, which is very odd.

Thanks,

--
Jonathan Perkin                    pkgsrc.smartos.org
Open Source Complete Cloud   www.tritondatacenter.com


Home | Main Index | Thread Index | Old Index