Re: platform-specific patches

[Brook Milligan <brook%nmsu.edu@localhost>]

> On Dec 30, 2024, at 13:31, Ismael Luceno <ismael%iodev.co.uk@localhost> wrote:
> 
> On 30/Dec/2024 11:06, Brook Milligan wrote:
>>> On Dec 30, 2024, at 05:17, Ismael Luceno <ismael%iodev.co.uk@localhost> wrote:
>>> On 29/Dec/2024 21:42, Thomas Klausner wrote:
>>>> The pkgsrc patches for Darwin x86_64 can easily be made a separate
>>>> patchset and put on ftp.netbsd.org, and then only applied in the
>>>> Darwin x86_64 case. That would solve this problem with minimal effort.
>>> 
>>> I wonder... How much effort would it be to make the patches universal?
>> 
>> The homebrew patchset for gcc12 is over 16k lines and hits 256 files.
>> 
>> I expect that integrating all of that into pkgsrc would be a lot
>> of work and highly error prone.
> 
> That's obvious, but I wonder exactly how much.

I am not sure, but also not particularly inclined to find out.

> What about GCC 15, are the changes upstreamed already?

The patches that I used for Darwin/x86_64 came directly from the upstream code base, so I expect they are not needed for gcc15.

>> I also expect that supporting platform-specific patches within
>> pkgsrc would be a more straightforward, and general, solution.
> 
> I'm not so sure it's sustainable, through history many GCC ports have
> died because of this approach, why would it be different within pkgsrc?
> (it may be even worse if we don't align with other communities)

Fair point.  Perhaps there are no other packages that require platform-specific patches, in which case this is not needed.

Cheers,
Brook