Re: Removing built-in support for sqlite3

[David Holland <dholland-pkgtech%netbsd.org@localhost>]

On Tue, Jul 23, 2024 at 08:07:19AM +0200, Thomas Klausner wrote:
 > >  > There is currently no way to require a sqlite3 version that has a
 > >  > particular feature enabled.
 > > 
 > > Does it not provide a config header?
 > 
 > I don't understand how this addresses the point.  If today I wanted
 > sqlite3 with FOO_FEATURE enabled, how do I do that?

If it installed a sqlite3_config.h file or something (it apparently
doesn't) it would be reasonably straightforward to have the builtin
infrastructure check that.

Since it doesn't, that won't work.

 > >  > I think heimdal was already discussed in this thread.
 > > 
 > > Yes, with various proposed hacks instead of handling it with the
 > > infrastructure we already have for the purpose.
 > 
 > The hack is to switch to pkgsrc heimdal?
 > What is the "infrastructure we already have for the purpose"?

The logic that sets USE_BUILTIN to no for P when P depends on Q and
Q has USE_BUILTIN set to no.

(Which, as I've posted about a couple times, is currently broken, but
it needs to be fixed because it affects things in X.)

 > >  > > Is there any reason to do that vs. just setting BUILDLINK_API_DEPENDS
 > >  > > so the version in question isn't used?
 > >  > 
 > >  > The problem is that many packages depend on sqlite3, and having two
 > >  > versions in the mix means you have a risk of linking both the base
 > >  > version and the pkgsrc version.
 > > 
 > > That's what a global BUILDLINK_API_DEPENDS is for, isn't it?
 > 
 > I read this as: If only one of the packages in pkgsrc wants a newer
 > sqlite3 and the other ones are happy with the old one, we need to bump
 > the global BUILDLINK_API_DEPENDS. Or what do you mean?

That was in response to "the version is not up to date". If pkgsrc
needs a newer version than the builtin one, then the
BUILDLINK_API_DEPENDS should be set so the builtin one gets rejected.
This happens routinely with X packages.

Without a way to check the build options, there's no useful way to
reject inadequate builtin ones besides blacklisting them by OS
version.

But it's still better to keep the builtin logic, even if there's
currently no extant version in the field it'll accept, so that other
packages that depend on sqlite get automatically built from pkgsrc.

-- 
David A. Holland
dholland%netbsd.org@localhost