Andrew Randrianasulu <randrianasulu%gmail.com@localhost> writes:
> I wonder when I should enable additional architectures for testing? Before
> package enters (hopefully) main pkgsrc tree or after?
I don't follow "enable". Generally, a package should run on any
architecture and if not it's a bug. If it's known not to run on some
system, then BROKEN_ON for that system, written narrowly to only include
what is known to fail, is ok.
I do not have many systems, definitely not AIX or Solaris, or much of non-x86 ....
ONLY_FOR/NOT_FOR is very limited. It's only when there is an
architectural reason why the package does not make sense on that system.
We use somewhat strange feature when number of png files concatenated together and put as .o object in final executable. This is ... not very portable (I was unable to make it works on macos x) and we also use /proc filesystem (so OpenBSD probably out).
Also, right now env. variable BSD=1 (this signals to our build system to omit few features related to signals and thread debugging) is not conditional in Makefile. (hopefully easy to fix, but again, I do not have working pkgsrc outside of single VM.)
The standard example is that if an OS has an unusual kernel feature, and
the point of the package is to be userland control for that feature.
A package where upstream has a nonportable implementation and lacks
support for a system is tagged as BROKEN_ON, if it would be conceptually
reasonable for upstream to extend support. (Or, implement in such a way
that it relies on POSIX and does not need per-OS support.)
It is never ok to limit to systems that have been tested.
It is reasonable to have a test item in TODO, with notes where it has
been verified to work.
Well, as I said source builds for me on Linux/ppc but does not start. So, I completely rely on non-automatic reports in this area ...
Just to clarify, you think I should remove _ONLY_FOR_PLATFORM_= line from Makefile, let autobuilders do their thing, then re-add BROKEN_ON based on result? Where I can see list of platforms where autobuild fails for my specific package? Should I somewhat manually trigger builds on server(s) somewhere?