Re: Fix mk/fetch/github.mk

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Tue, Feb 13, 2024 at 08:40:20AM -0500, Greg Troxel wrote:
> I really don't like magic that looks at the "tag" and decides if it is a
> hash or a tag.  AFAIK it is not forbidden to use a sha-1 as a tag, even
> though that's asking for trouble.
> 
> I wonder if we should use GITHUB_HASH instead of TAG when the value
> is...  actually a commit hash instead of a tag, and then have
> GITHUB_TYPE default to hash when GITHUB_HASH is defined.
> 
> That results in more changes, but it leads to IMHO much cleaner
> semantics.

I have packages in pkgsrc (not WIP) which actually use hashes as GITHUB_TAG.
There are 3 of them in geography/opencpn-plugin-*

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--