Fw: Re: Fix mk/fetch/github.mk

[pin <voidpin%protonmail.com@localhost>]

Sent with Proton Mail secure email.

------- Forwarded Message -------
From: pin <voidpin%protonmail.com@localhost>
Date: On Tuesday, February 13th, 2024 at 2:46 PM
Subject: Fw: Re: Fix mk/fetch/github.mk
To: Greg Troxel <gdt%lexort.com@localhost>, Adam <adam%netbsd.org@localhost>, Benny Siegert <bsiegert%gmail.com@localhost>


> > I really don't like magic that looks at the "tag" and decides if it is a
> > hash or a tag. AFAIK it is not forbidden to use a sha-1 as a tag, even
> > though that's asking for trouble.
> > 
> > I wonder if we should use GITHUB_HASH instead of TAG when the value
> > is... actually a commit hash instead of a tag, and then have
> > GITHUB_TYPE default to hash when GITHUB_HASH is defined.
> > 
> > That results in more changes, but it leads to IMHO much cleaner
> > semantics.
> 
> 
> So, it breaks url2pkg as well :(
> 
> url2pkg https://github.com/elves/elvish/archive/2c97aeff60656856d12af9e5ac0280b60a0781ab.tar.gz
> ===> Cleaning for elvish-2c97aeff60656856d12af9e5ac0280b60a0781ab
> 
> => Bootstrap dependency digest>=20211023: found digest-20220214
> 
> WARNING: [license.mk] Every package should define a LICENSE.
> => Fetching 2c97aeff60656856d12af9e5ac0280b60a0781ab-2c97aeff60656856d12af9e5ac0280b60a0781ab.tar.gz
> 
> Requesting https://github.com/elves/elvish/archive/refs/tags/2c97aeff60656856d12af9e5ac0280b60a0781ab.tar.gz
> Redirected to https://codeload.github.com/elves/elvish/tar.gz/refs/tags/2c97aeff60656856d12af9e5ac0280b60a0781ab
> Requesting https://codeload.github.com/elves/elvish/tar.gz/refs/tags/2c97aeff60656856d12af9e5ac0280b60a0781ab
> ftp: Error retrieving file `404 Not Found' fetch: Unable to fetch expected file 2c97aeff60656856d12af9e5ac0280b60a0781ab-2c97aeff60656856d12af9e5ac0280b60a0781ab.tar.gz Trying [2a04:4e42:14::262]:443 ... ftp: Can't connect to` 2a04:4e42:14::262:443': No route to host
> Trying 151.101.85.6:443 ...
> Requesting https://cdn.NetBSD.org/pub/pkgsrc/distfiles/elvish/2c97aeff60656856d12af9e5ac0280b60a0781ab-2c97aeff60656856d12af9e5ac0280b60a0781ab.tar.gz
> ftp: Error retrieving file `404 Not Found' fetch: Unable to fetch expected file 2c97aeff60656856d12af9e5ac0280b60a0781ab-2c97aeff60656856d12af9e5ac0280b60a0781ab.tar.gz Trying [2001:660:3302:282a:204:75ff:fe9f:9e11]:80 ... ftp: Can't connect to` 2001:660:3302:282a:204:75ff:fe9f:9e11:80': No route to host
> Trying 132.227.74.11:80 ...
> Requesting http://ftp.fr.NetBSD.org/pub/pkgsrc/distfiles/elvish/2c97aeff60656856d12af9e5ac0280b60a0781ab-2c97aeff60656856d12af9e5ac0280b60a0781ab.tar.gz
> ftp: Error retrieving file `404 Not Found' fetch: Unable to fetch expected file 2c97aeff60656856d12af9e5ac0280b60a0781ab-2c97aeff60656856d12af9e5ac0280b60a0781ab.tar.gz Trying [2001:470:a085:999::21]:443 ... ftp: Can't connect to` 2001:470:a085:999::21:443': No route to host
> Trying 199.233.217.201:443 ...
> Requesting https://ftp.NetBSD.org/pub/pkgsrc/distfiles/elvish/2c97aeff60656856d12af9e5ac0280b60a0781ab-2c97aeff60656856d12af9e5ac0280b60a0781ab.tar.gz
> ftp: Error retrieving file `404 Not Found'
> fetch: Unable to fetch expected file 2c97aeff60656856d12af9e5ac0280b60a0781ab-2c97aeff60656856d12af9e5ac0280b60a0781ab.tar.gz
> *** Error code 1
> 
> Stop.
> make: stopped in /usr/pkgsrc/wip/pedro
> Traceback (most recent call last):
> File "/usr/pkg/bin/url2pkg", line 1328, in <module>
> 
> main(sys.argv, Globals())
> File "/usr/pkg/bin/url2pkg", line 1315, in main
> initial_lines = Generator(url).generate_package(g)
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> File "/usr/pkg/bin/url2pkg", line 646, in generate_package
> g.bmake('clean', 'distinfo', 'extract')
> File "/usr/pkg/bin/url2pkg", line 116, in bmake
> subprocess.check_call([self.make, *args], cwd=self.pkgdir, env=env)
> File "/usr/pkg/lib/python3.11/subprocess.py", line 413, in check_call
> raise CalledProcessError(retcode, cmd)
> subprocess.CalledProcessError: Command '['/usr/bin/make', 'clean', 'distinfo', 'extract']' returned non-zero exit status 1.
> Exception: url2pkg exited with 1
> [tty 16]:1:1-95: url2pkg https://github.com/elves/elvish/archive/2c97aeff60656856d12af9e5ac0280b60a0781ab.tar.gz