portability checking script does not check portability (example: biology/libpll)

["Dr. Thomas Orgis" <thomas.orgis%uni-hamburg.de@localhost>]

Hi,

wiz pointed out to me that he had to clean up after me with
biology/libpll and assumed I don't have PKG_DEVELOPER=yes.

But I do. This is the respective offender:

$NetBSD: patch-man_Makefile.in,v 1.1 2024/01/24 16:36:57 wiz Exp $

Fix unportable test(1) operator.

--- man/Makefile.in.orig	2024-01-24 16:35:18.664780397 +0000
+++ man/Makefile.in
@@ -533,7 +533,7 @@ uninstall-man: uninstall-man3
 
 @HAVE_PS2PDF_TRUE@libpll_manual.pdf : libpll.3
 @HAVE_PS2PDF_TRUE@	TEMP=$$(mktemp temp.XXXXXXXX) ; \
-@HAVE_PS2PDF_TRUE@	if [ $$(uname) == "Darwin" ] ; then \
+@HAVE_PS2PDF_TRUE@	if [ $$(uname) = "Darwin" ] ; then \
 @HAVE_PS2PDF_TRUE@		${SED} -e 's/\\-/-/g' $< | \
 @HAVE_PS2PDF_TRUE@		iconv -f UTF-8 -t ISO-8859-1 > $$TEMP ; \
 @HAVE_PS2PDF_TRUE@	else \

I removed that patch again and re-checked. I verified all the variables
pointing towards running the portability check … and also I see

=> Replacing install-sh with pkgsrc version
=> Checking for portability problems in extracted files  
checking for a BSD-compatible install... /bin/install -c -o thomas -g thomas
checking whether build environment is sane... yes

Even when I manually run the test script:

09:27:07 pkgsrc:libpll$ bmake build-env
=> Bootstrap dependency digest>=20211023: found digest-20220214
=> Entering the build environment for libpll-0.3.2nb1  
$ PREFIX=/data/pkg                                       \
PATCHDIR=/data/projekte/pkgsrc/pkgsrc/biology/libpll/patches  \
CHECK_PORTABILITY_EXPERIMENTAL=no \
sh /data/projekte/pkgsrc/pkgsrc/mk/check/check-portability.sh> > > 
$ echo $?
0

All that while

$ grep == man/Makefile.in
    if (++n[$$2] == $(am__install_max)) \
@HAVE_PS2PDF_TRUE@	if [ $$(uname) == "Darwin" ] ; then \

So something deep inside the script decides that this is fine for me
but not for elsepeople.

Anyone with more knowledge about those workings who could point out how
this could be (if the script is not plainly broken for me)?



Alrighty then,

Thomas

-- 
Dr. Thomas Orgis
HPC @ Universität Hamburg