Re: wip/glusterfs to pkgsrc filesystems/glusterfs

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Mon, Feb 27, 2023 at 10:18:24PM +0100, Alexander Schreiber wrote:
> so I've updated pkgsrc wip/glusterfs to 10.3 and didn't get any complaints
> after announcing that here and on pkgsrc-users (I hope at least someone
> else tried it).
>
> How to I get this from wip to actual pkgsrc?

You find a developer to commit it for you :)

I've tried building it but it failed early for me:

=> Verifying package-install for ../../devel/userspace-rcu
=> Bootstrap dependency digest>=20211023: found digest-20220214
ERROR: This package is not available for these platforms: NetBSD-[0-5]*-*.
ERROR: This package has set PKG_SKIP_REASON:
ERROR: userspace-rcu-0.12.1 is not available for NetBSD-10.99.2-x86_64
*** Error code 1

I've fixed this one.

Then I see a couple of these:
WARNING: [replace-interpreter] Skipping non-existent file "contrib/ipaddr-py/ipaddr.py".
WARNING: [replace-interpreter] Skipping non-existent file "geo-replication/src/peer_mountbroker.py".
WARNING: [replace-interpreter] Skipping non-existent file "geo-replication/syncdaemon/changelogagent.py".
...
WARNING: [replace-interpreter] Skipping non-existent file "extras/ganesha/scripts/copy-export-ganesha.sh".
WARNING: [replace-interpreter] Skipping non-existent file "extras/geo-rep/slave-upgrade.sh".

Also, PKGREVISION has not been removed (we remove this for every update).


Some warnings to report to upstream if you're already in contact with them:

One defined seems to be wrong:
../../../libglusterfs/src/glusterfs/common-utils.h: In function 'gf_time_fmt_tv':
../../../libglusterfs/src/glusterfs/common-utils.h:862:53: warning: format '%ld' expects argument of type 'long int', but argument 6 has type 'suseconds_t' {aka 'int'} [-Wformat=]
  862 |             len = snprintf(dst + pos, sz_dst - pos, ".%" GF_PRI_SUSECONDS,
      |                                                     ^~~~
  863 |                            tv->tv_usec);
      |                            ~~~~~~~~~~~
      |                              |
      |                              suseconds_t {aka int}


posix-inode-fd-ops.c: In function 'posix_get_ancestry_non_directory':
posix-inode-fd-ops.c:3497:46: warning: '%s' directive output may be truncated writing up to 4081 bytes into a region of size 37 [-Wformat-truncation=]
 3497 |         snprintf(pgfidstr, sizeof(pgfidstr), "%s",
      |                                              ^~~~


During installation I have another issue:

=> Checking for non-existent script interpreters in glusterfs-10.3nb9
ERROR: [check-interpreter.mk] The interpreter "/bin/bash" of "/scratch/wip/glusterfs/work/.destdir/usr/pkg/libexec/glusterfs/scripts/secondary-upgrade.sh" does not exist.
*** Error code 1

You'll probably want to add an appropriate REPLACE_SH or REPLACE_BASH
for this (the latter means that you'll also have to change "bash" to
"bash:run" in USE_TOOLS).

Please set PKG_DEVELOPER=yes in your /etc/mk.conf then you'll see
these warnings yourself.

Can you please fix these?

Thanks,
 Thomas