FreeBSD needs libpthread-stubs

[Frédéric Fauberteau <triaxx%NetBSD.org@localhost>]

Hi,

I would update x11/xf86-video-ati on FreeBSD. I got an error for the three following packages:
- x11/libdrm
- graphics/MesaLib
- x11/xf86-video-ati
which pointed the lake of pthread-stubs.

I was able to build them by including wip/libpthread-stubs/buildlink3.mk (i.e. patch below). Is there any objection to import wip/libpthread-stubs to devel/libpthread-stubs? If no, is it correct to conditionally include its buildlink3.mk as in patch below?

cvs diff: Diffing x11/libdrm
Index: x11/libdrm/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/x11/libdrm/Makefile,v
retrieving revision 1.104
diff -u -r1.104 Makefile
--- x11/libdrm/Makefile 9 Sep 2022 15:28:16 -0000       1.104
+++ x11/libdrm/Makefile 31 Oct 2022 15:13:04 -0000
@@ -85,4 +85,7 @@
 X11_LIB_NAME?=         libdrm
 .include "../../meta-pkgs/modular-xorg/avoid-duplicate.mk"
 .include "../../devel/meson/build.mk"
+.if ${OPSYS} == "FreeBSD"
+.include "../../wip/libpthread-stubs/buildlink3.mk"
+.endif
 .include "../../mk/bsd.pkg.mk"
cvs diff: Diffing x11/libdrm/patches
cvs diff: Diffing graphics/MesaLib
Index: graphics/MesaLib/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/graphics/MesaLib/Makefile,v
retrieving revision 1.205
diff -u -r1.205 Makefile
--- graphics/MesaLib/Makefile   11 Aug 2022 05:08:38 -0000      1.205
+++ graphics/MesaLib/Makefile   31 Oct 2022 15:13:05 -0000
@@ -192,5 +192,8 @@
 .include "../../devel/zlib/buildlink3.mk"
 .include "../../lang/python/tool.mk"
 .include "../../textproc/expat/buildlink3.mk"
+.if ${OPSYS} == "FreeBSD"
+.include "../../wip/libpthread-stubs/buildlink3.mk"
+.endif
 .include "../../mk/atomic64.mk"
 .include "../../mk/bsd.pkg.mk"
cvs diff: Diffing graphics/MesaLib/patches
cvs diff: Diffing x11/xf86-video-ati
Index: x11/xf86-video-ati/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/x11/xf86-video-ati/Makefile,v
retrieving revision 1.56
diff -u -r1.56 Makefile
--- x11/xf86-video-ati/Makefile 19 Jul 2022 11:59:05 -0000      1.56
+++ x11/xf86-video-ati/Makefile 31 Oct 2022 15:13:05 -0000
@@ -33,4 +33,7 @@
 BUILDLINK_API_DEPENDS.modular-xorg-server+=    modular-xorg-server>=1.18.1
 .include "../../x11/modular-xorg-server/buildlink3.mk"
 .include "../../x11/xorgproto/buildlink3.mk"
+.if ${OPSYS} == "FreeBSD"
+.include "../../wip/libpthread-stubs/buildlink3.mk"
+.endif
 .include "../../mk/bsd.pkg.mk"