Re: hacks.mk?

[Jonathan Perkin <jperkin%mnx.io@localhost>]

* On 2022-10-26 at 10:09 BST, nia wrote:

> I use hacks.mk... sometimes, but I often wonder whether anyone reads
> and reviews the hacks to make sure they're still valid.
>
> Should we move to putting such hacks in the main Makefile so people
> can review them, for example, while updating packages to determine
> if they're still relevant?

Personally I absolutely hate them, and would love to see them go away.

Things like this:

  https://github.com/NetBSD/pkgsrc/blob/trunk/x11/pixman/hacks.mk#L7-L16

end up hidden for many years.

Just put them in Makefile, where the chances that someone will spot that 
the above disables optimisations for e.g. clang because it doesn't limit 
the checks to PKGSRC_COMPILER:Mgcc, are vastly improved.

--
Jonathan Perkin   -   mnx.io   -   pkgsrc.smartos.org
Open Source Complete Cloud   www.tritondatacenter.com