Re: Latest samba4 changes & heimdal breakage

[Adam <adam%netbsd.org@localhost>]

> I'm running 4.15.9 locally (not as AD), patched to expect the 2.5.2
> ldb from pkgsrc rather than its bundled 2.4.4 - pkgsrc source at
> https://sync.absd.org/pkgsrc-samba-4.15.9.txz for anyone who just
> wants to build an up to date samba4 version (regarding security
> patches) without expending any effort.
> 
> I think the obvious options are:
> 1. patch up the bundled 4.16.x heimdal to build on NetBSD (looks like
> configurery fail)
> 2. downgrade to 4.15.x for now, optionally adding both 4.15.x and
> 4.16.x samba packages
> 3. make samba4 use pkgsrc mit-krb5 on NetBSD
> 4. other wacky options such as trying to copy the 4.15.x bundled
> heimdal into 4.16.x, but effort better spent on other choices
> 
> A sample error from the build is below (line 40 of stdio.h is the
> include of cdefs.h)
> 
> In file included from /usr/include/stdio.h:40:0,
>                 from ../../lib/replace/../replace/replace.h:48,
>                 from ../../third_party/heimdal_build/config.h:10,
>                 from ../../third_party/heimdal/lib/roken/bswap.c:34:
> ../../third_party/heimdal/lib/roken/bswap.c:40:1: error: expected
> declaration specifiers or '...' before '__builtin_constant_p'
> bswap64 (uint64_t val)
> ^
> 
> David

I couldn't build Samba with external Heimdall. It might require heavy patching which I would rather not do. It seems that, for the time being, Samba has to use the embedded Heimdall.
Anyway, I've committed 4.16.4.

The error mentioned above pops up when external Heimdal is buildlinked.

Kind regards,
Adam