Re: Latest samba4 changes & heimdal breakage

[Jason Thorpe <thorpej%me.com@localhost>]

> On Aug 9, 2022, at 10:24 AM, Martin Husemann <martin%duskware.de@localhost> wrote:
> 
> On Tue, Aug 09, 2022 at 05:52:16PM +0100, David Brownlee wrote:
>> A sample error from the build is below (line 40 of stdio.h is the
>> include of cdefs.h)
>> 
>> In file included from /usr/include/stdio.h:40:0,
>>                 from ../../lib/replace/../replace/replace.h:48,
>>                 from ../../third_party/heimdal_build/config.h:10,
>>                 from ../../third_party/heimdal/lib/roken/bswap.c:34:
>> ../../third_party/heimdal/lib/roken/bswap.c:40:1: error: expected
>> declaration specifiers or '...' before '__builtin_constant_p'
>> bswap64 (uint64_t val)
>> ^
> 
> bswap64 is a define in our headers, you need to #undef it in that .c file
> (probably trying to implement a lib function of that same name), or exclude
> the file from the build for NetBSD (as we already provide it).

Why is #including <stdio.h> bringing bswap64 into the namespace?

-- thorpej