Re: libreswan 4.7 for wip

[Andrew Cagney <andrew.cagney%gmail.com@localhost>]

On Wed, 15 Jun 2022 at 11:36, Greg Troxel <gdt%lexort.com@localhost> wrote:
>
>
> Andrew Cagney <andrew.cagney%gmail.com@localhost> writes:
>
> >> - It's not actually in wip (did you just not push?).
> >
> > hmm, write access, hmm
>
> That's not hard.  We've probably handed out access to a kiloperson just
> for asking.
>
> https://pkgsrc.org/wip/
> https://pkgsrc.org/wip/users/

Pushed.

> >> - There is no COMMIT_MSG (for use when committing the cvs add).
> >
> > Ah.
> >
> > Would it be possible for url2pkg to generate a stub for this file and
> > pkglint to, er, lint it when present?
> > (credit where credit is due: url2pkg did a pretty good job)
>
> pkglint could complain if it isn't present in wip.  In pkgsrc proper it
> doesn't belong (checked in).
>
> (The point is to reduce the amount of work someone with CVS write access
> has to do to import a completed package.)
>
> >> - HOMEPAGE seems wrong.
> >
> > The contents of DESCR. which url2pkg cribbed from somewhere, are also
> > wrong.  I need to find "somewhere" and get it fixed.

It's an upstream problem.  Multiple descriptions and all slightly different.

> Sure - just mentioning it since you asked for comments, and it didn't
> seem ready.
>
> > But this brings up a question.  How should I document limitations such
> > as https://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=56836
>
> To first order, you don't, because that is not a bug in the package.

Works for me.

> >> - patch to mandir is not really about NetBSD so much as pkgsrc.  patch
> >>   should have a patch comment, not pasted in git commit message, and if
> >>   this is entirely adjusting to pkgsrc norms, an explanation that it
> >>   doesn't belong upstream (in lieu of the otherwise required URL to
> >>   upstream bug report or merge request).
> >
> > It was cherry-picked from upstream so from Libreswan's POV it is
> > correct.  I'll add a PKGSRC cover note, something like "Backported
> > from upstream".
>
> The convention of /usr/pkg/man is a pkgsrc thing.  /usr/share/man is
> where base man pages go.  hier(7) does not seem to specify where man
> pages go in /usr/local or some other random prefix.
>
> And, the ${PREFIX}/man convention is used with pkgsrc for every
> operating system.  So this change is properly used for building on any
> system with pkgsrc, not for building on NetBSD.

This area will likely need further work.

> > Also, is there a way to package mainline (aka unstable) in parallel?
> > Or would that mean a separate libreswan-unstable package?  Anyone
> > reporting a problem to upstream libreswan will likely, eventually, be
> > asked to test libreswan's mainline.
>
> Yes, add libreswan-git and see mk/fetch/github.mk or equivalent.

Ok.