Re: Update mpg123 during 2021Q1 freeze?

["Dr. Thomas Orgis" <thomas.orgis%uni-hamburg.de@localhost>]

Am Wed, 24 Mar 2021 08:59:40 +0100
schrieb Thomas Klausner <wiz%NetBSD.org@localhost>: 

> The update is definitely fine, mpg123 is a leaf package AFAIK.

To be honest, that would surprise me, as I worked hard to eliminate old
forks of its code in other software to be replaced with libmpg123.

$ find . -type f | xargs grep mpg123/buildlink | grep -v mpg123-
./audio/alure/options.mk:.include "../../audio/mpg123/buildlink3.mk"
./audio/cantata/Makefile:.include "../../audio/mpg123/buildlink3.mk"
./audio/py-audiotools/Makefile:.include "../../audio/mpg123/buildlink3.mk"
./audio/gst-plugins1-mpg123/Makefile:.include "../../audio/mpg123/buildlink3.mk"
./audio/libopenmpt/Makefile:.include "../../audio/mpg123/buildlink3.mk"
./audio/musicpd/Makefile:.include "../../audio/mpg123/buildlink3.mk"
./audio/terminatorx/Makefile:.include "../../audio/mpg123/buildlink3.mk"
./audio/audacious-plugins/Makefile:.include "../../audio/mpg123/buildlink3.mk"
./audio/mp3gain/Makefile:.include "../../audio/mpg123/buildlink3.mk"
./audio/qmmp/Makefile:.include "../../audio/mpg123/buildlink3.mk"
./audio/SDL2_mixer/Makefile:.include "../../audio/mpg123/buildlink3.mk"
./textproc/translate-shell/Makefile:.include "../../audio/mpg123/buildlink3.mk"
./emulators/vice/Makefile:.include "../../audio/mpg123/buildlink3.mk"
./emulators/wine/Makefile:.include "../../audio/mpg123/buildlink3.mk"
./multimedia/mplayer-share/options.mk:.    include "../../audio/mpg123/buildlink3.mk"
./multimedia/vlc/Makefile:.include "../../audio/mpg123/buildlink3.mk"
./games/love11/Makefile:.include "../../audio/mpg123/buildlink3.mk"
./games/easyrpg-player/options.mk:.include "../../audio/mpg123/buildlink3.mk"
./games/love010/Makefile:.include "../../audio/mpg123/buildlink3.mk"
./games/love07/Makefile:.include "../../audio/mpg123/buildlink3.mk"
./games/quakespasm/Makefile:.include "../../audio/mpg123/buildlink3.mk"
./games/love09/Makefile:.include "../../audio/mpg123/buildlink3.mk"
./games/love08/Makefile:.include "../../audio/mpg123/buildlink3.mk"

But as I said, the library only changes in a patchlevel, without API
difference. Same for the mpg123 binary, that several tools use.

These should be fine, as

> * backwards compatibility with older CPUs on the same platform

there is no instruction set in the default CFLAGS,

> * pkgsrc user preferences (setting CFLAGS themselves, e.g. using devel/cpuflags)

those are appended, i.e. override the defaults, and

> * compiler compatibility

the flags only apply if GCC is detected.

Btw., the mpg123 default flags look very similar to
multimedia/mplayer-share/Makefile.cflags.

> That said, since I assume you'll be maintaining mpg123 in pkgsrc,
> please go ahead with your change if you think it's for the best
> considering these points.

Unless someone severely objects, I assume that, too;-) I will get to
implementing the changes today.


Alrighty then,

Thomas

-- 
Dr. Thomas Orgis
HPC @ Universität Hamburg