Re: MYSQL_VERSION in mk/mysql.buildlink3.mk

[Juraj Lutter <otis%NetBSD.org@localhost>]

> On 23 Oct 2020, at 00:21, Roland Illig <roland.illig%gmx.de@localhost> wrote:
> 
> On 20.10.2020 23:32, Juraj Lutter wrote:
>> Hi,
>> 
>> some of you may know that pgsql.buildlink3.mk sets PGSQL_VERSION
>> but I did not find something similar for MySQL in mysql.buildlink3.mk.
>> 
>> Here is a small patch that sets it:
>> https://pkgsrc-smartos.wilbury.net/patches/mysql_version_mk.diff
>> 
>> If there are no serious objections, it can be committed.
> 
> The patch is missing the documentation for that variable.  The
> documentation should describe the variable and demonstrate the format of
> the version number by giving an example value.
> 
> That variable should also be added to _SYS_VARS.mysql in line 32, so
> that "bmake show-all-mysql" shows it.  Unfortunately, the list of
> pkglint warnings for that file is quite long, but the last warning is
> the interesting one:
> 
> pkglint ../../mk/mysql.buildlink3.mk
> ...
> WARN: ../../mk/mysql.buildlink3.mk:134: Variable MYSQL_VERSION is
> defined but not mentioned in the _VARGROUPS section.
> 
> The documentation in the header of mk/pgsql.buildlink3.mk is not a good
> copy-and-paste template since it only repeats the information from the
> _VARGROUPS section, without giving any helpful additional information.
> The documentation for mk/mysql.buildlink3.mk doesn't have to be as
> detailed as in mk/subst.mk, but a little more than in
> mk/pgsql.buildlink3.mk would be good.
> 

That file will need a lof ot work, obviously.
Not only MYSQL_VERSION is mentioned in WARN section.

otis