tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Github versions



On 2020-07-26 14:15, Jason Bacon wrote:
On 2020-07-26 14:03, John Nemeth wrote:
On Jul 26,  1:49pm, Jason Bacon wrote:
} On 2020-05-19 12:34, Roland Illig wrote:
} > On 19.05.2020 16:35, Jason Bacon wrote:
} >>
} >> I'd like to propose some additions to the developer's guide regarding
} >> Github repos:
} >>
} >> https://www.netbsd.org/docs/pkgsrc/fixes.html#build.fetch.github
} >
} > Sounds great to me, I like the clear instructions that also reveal the
} > general rules to follow.
} >
} > While there, you could also fix the indentation of the #GITHUB_PROJECT=
} > lines.
}
} Is there a standard pre-commit procedure for changes to the guide
} besides just running [b]make and inspecting the output?

      The Guide itself (in Part IV if I recall correctly) contains
the updating instructions.

}-- End of excerpt from Jason Bacon
Ah, there it is...  There is no part IV actually, but it's in appendix E way down at the bottom.

https://www.netbsd.org/docs/pkgsrc/editing.html

Thanks,

    JB

Finally got to this.  Appendix E.2 neglects to mention that you need htdocs in a sibling directory of the pkgsrc tree you're editing. "bmake regen" will fail without it.  I propose the following patch:

Index: files/editing.xml
===================================================================
RCS file: /cvsroot/pkgsrc/doc/guide/files/editing.xml,v
retrieving revision 1.16
diff -u -r1.16 editing.xml
--- files/editing.xml   24 Feb 2020 21:13:56 -0000      1.16
+++ files/editing.xml   11 Aug 2020 20:48:11 -0000
@@ -40,6 +40,9 @@

        <procedure>

+       <step><para>Make sure you have checked out the htdocs repository
+       into a sibling directory of your pkgsrc directory.</para></step>
+
        <step><para>Make sure you have the packages needed to
        regenerate the pkgsrc guide (and other XML-based NetBSD
        documentation) installed. These are automatically installed when




Home | Main Index | Thread Index | Old Index