Re: Change of default version of PHP and Ruby

[Takahiro Kambe <taca%NetBSD.org@localhost>]

Hi,

In message <20191127161056.63sxvompun2ryhd2@danbala>
	on Wed, 27 Nov 2019 17:10:56 +0100,
	Thomas Klausner <tk%giga.or.at@localhost> wrote:
> On Thu, Nov 28, 2019 at 01:02:45AM +0900, Takahiro Kambe wrote:
>> Hi,
>> 
>> I'm planning to change default version of PHP and Ruby.
>> 
>> PHP
>> 	o current default version	7.1.x
>> 	o new default version		7.3.x
> 
> We should find a workaround for -current and the ifunc problem first.
Dose attached patch solve the problem?

> Except for that I'm fine with the changes.
Thank you for your quick reply!

-- 
Takahiro Kambe <taca%NetBSD.org@localhost>

Index: Makefile.common
===================================================================
RCS file: /cvsroot/pkgsrc/lang/php73/Makefile.common,v
retrieving revision 1.1
diff -u -u -r1.1 Makefile.common
--- Makefile.common	15 Dec 2018 17:12:44 -0000	1.1
+++ Makefile.common	27 Nov 2019 16:39:16 -0000
@@ -13,6 +13,10 @@
 # needed due to (broken?) configure checks in php-xmlrpc and php5-dom
 CONFIGURE_ENV+=		PHP_LIBXML_SHARED="1"
 
+.if ${OPSYS} == "NetBSD"
+CONFIGURE_ARGS+=	ax_cv_have_func_attribute_ifunc=no
+.endif
+
 .include "../../mk/compiler.mk"
 .if !empty(PKGSRC_COMPILER:Mclang)
 # configure test gets confused by wrappers dropping -R /usr/lib