tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: py-Scientific fix

* On 2019-03-28 at 00:17 GMT, Jason Bacon wrote:

> On 3/27/19 5:33 PM, Jonathan Perkin wrote:
> > * On 2019-03-27 at 22:15 GMT, Jason Bacon wrote:
> > 
> > > +PLATFORM!=    ${PYTHONBIN} -c "import sys; print sys.platform"
> > This should be wrapped in an ".if exists(${PYTHONBIN}", otherwise
> > users and bulk builds will get strange errors when running non-build
> > targets in that directory.
> I'm not seeing that - all targets I've tried work fine for me (fetch, clean,
> patch, etc.).  I think including defines it regardless of
> target.

Try uninstalling python.  This will be the case e.g. during pbulk's
scanning phase where no dependencies are installed but it calls the
pbulk-index target in each package directory.

> > Also might be worth changing the variable to PYTHON_PLATFORM or
> > something, PLATFORM seems generic enough that it might be used at some
> > point in the infrastructure.
> Have you been talking to the voice in my head?  It said the same thing as I
> was coding this...
> Better?

Yes, joerg's right, :sh is preferable.

Jonathan Perkin  -  Joyent, Inc.  -

Home | Main Index | Thread Index | Old Index