tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: py-Scientific fix

* On 2019-03-27 at 22:15 GMT, Jason Bacon wrote:

> +PLATFORM!=    ${PYTHONBIN} -c "import sys; print sys.platform"

This should be wrapped in an ".if exists(${PYTHONBIN}", otherwise
users and bulk builds will get strange errors when running non-build
targets in that directory.

Also might be worth changing the variable to PYTHON_PLATFORM or
something, PLATFORM seems generic enough that it might be used at some
point in the infrastructure.

Otherwise I'm fine for this to go in during the freeze.

Jonathan Perkin  -  Joyent, Inc.  -

Home | Main Index | Thread Index | Old Index