Re: Request for review and import: libxls, libxlsxwriter, sc-im

["Sijmen J. Mulder" <ik%sjmulder.nl@localhost>]

Hi Benny,

On Tue, 11 Dec 2018 14:39:15 +0100 Benny Siegert <bsiegert%gmail.com@localhost>
wrote:
> The patch to Makefile is wrong, in that it never uses -ldl. I think
> you should include "../../mk/dlopen.buildlink3.mk" and use the values
> of DL_CFLAGS, DL_LDFLAGS and/or DL_LIBS.

Now I have:

   DL_AUTO_VARS=   yes
   .include "../../mk/dlopen.buildlink3.mk"

But no -ldl in LDFLAGS, LDLIBS or even DL_LIBS (!) on Debian where it's
needed. Tracing back, the flag is first generated here:

dlopen.builtin.mk
  92  #
  93  # No need to add this to BUILDLINK_LIBS.dl since most GNU configure
  94  # scripts already check for -ldl themselves.
  95  #
  96  BUILDLINK_LDADD.dl+=    -ldl

I don't understand the comment. Don't we want DL_LIBS assigned
regardless of whatever a configure script finds out? Indeed, it's
BUILDLINK_LIBS.dl that's used:

dlopen.buildlink3.mk
  51  DL_LIBS=        ${BUILDLINK_LIBS.dl}

But BUILDLINK_LIBS.dl was never assigned to so DL_LIBS remains empty and
my build is broken.

Shouldn't dlopen.builtin.mk:96 be assigning BUILDLINK_LIBS instead? I
tested it and that does indeed cause DL_LIBS to have the flag.

Sijmen