Re: Request for review and import: libxls, libxlsxwriter, sc-im

[Benny Siegert <bsiegert%gmail.com@localhost>]

Regarding libxlsxwriter:
 - we usually do not explicitly set V=1 in MAKE_ENV. It's fine for
your debugging, but please remove before importing.

Regarding sc-im:
 - The patch to Makefile is wrong, in that it never uses -ldl. I think
you should include "../../mk/dlopen.buildlink3.mk" and use the values
of DL_CFLAGS, DL_LDFLAGS and/or DL_LIBS. Or perhaps just disable it on
NetBSD by adding

.if ${OSTYPE} == "NetBSD"
BUILDLINK_TRANSFORM+= rm:-ldl
.endif


On Mon, Dec 10, 2018 at 6:42 PM Sijmen J. Mulder <ik%sjmulder.nl@localhost> wrote:
>
> Hi all,
>
> Can someone review and import (if OK) the following three packages?
>
> wip/libxls - Extract cell data from legacy Microsoft Excel files
> wip/libxlsxwriter - C library for creating Microsoft Excel files
> wip/sc-im - Curses-based spreadsheet program based on sc
>
> Sijmen



-- 
Benny