Re: R package MASTER_SITES

[Roland Illig <roland.illig%gmx.de@localhost>]

Am 22.07.2018 um 16:51 schrieb Brook Milligan:
> It turn out that many (all?) of the R packages have a line like the
> following in their Makefiles:
> 
> MASTER_SITES=  ${MASTER_SITE_R_CRAN:=contrib/}
> 
> This is redundant with the same line in math/R/Makefile.extension,
> which all R packages should be including anyway.  I would like to
> remove these extra lines in individual packages in favor of the
> master version defined in math/R/Makefile.extension.  This will
> simplify individual R packages and the common single definition will
> actually be used as intended.
> 
> Thoughts?

It sounds great. I implemented this check in pkglint 5.5.15:

NOTE: math/R-ISLR/Makefile:4: Definition of MASTER_SITES is redundant
because of ../R/Makefile.extension:18.
NOTE: math/R-ISLR/Makefile:7: Definition of HOMEPAGE is redundant
because of ../R/Makefile.extension:21.
NOTE: math/R-ISwR/Makefile:4: Definition of MASTER_SITES is redundant
because of ../R/Makefile.extension:18.
NOTE: math/R-ISwR/Makefile:7: Definition of HOMEPAGE is redundant
because of ../R/Makefile.extension:21.

Pkglint currently doesn't fix them automatically because the check is
brand new and not proven in practice. It should be safe to use it to
find these issues and review them manually. Just run:

    pkglint -r --only "redundant because of" /usr/pkgsrc

Best,
Roland