Re: firefox 61 fails to build on netbsd-7

[Greg Oster <oster%netbsd.org@localhost>]

On Tue, 03 Jul 2018 06:22:47 +0900 (JST)
Ryo ONODERA <ryo%tetera.org@localhost> wrote:

> Hi,
> 
> From: Greg Troxel <gdt%lexort.com@localhost>, Date: Fri, 29 Jun 2018 11:11:45
> -0400
> 
> > 
> > Because it needs gcc 6.1 !!  
> 
> The following patch fixes www/firefox build with lang/gcc6
> under NetBSD/amd64 8.0_BETA.
> GCC 6 has changed math.h behavior.
> See https://gcc.gnu.org/gcc-6/porting_to.html .
> 
> And netbsd-7 has another Rust problem.
> I will investigate this.
> 
> Could you confirm that my patch is effective for NetBSD/{amd64.i386}
> 8.0_RC2?

With this patch firefox61 builds fine for me on 8.0_RC2 amd64 now!

Thanks!

Later...

Greg Oster

> Thank you.
> 
> Index: www/firefox/Makefile
> ===================================================================
> RCS file: /cvsroot/pkgsrc/www/firefox/Makefile,v
> retrieving revision 1.334
> diff -u -r1.334 Makefile
> --- www/firefox/Makefile	28 Jun 2018 13:52:37 -0000
> 1.334 +++ www/firefox/Makefile	2 Jul 2018 21:20:18 -0000
> @@ -23,6 +23,8 @@
>  CONFIGURE_ARGS+=	--enable-application=browser
>  
>  CFLAGS+=	-I${PREFIX}/include/nspr
> +# for lang/gcc6
> +CFLAGS+=	-D_GLIBCXX_INCLUDE_NEXT_C_HEADERS
>  
>  # workround for link of libxul.so etc.
>  LDFLAGS+=		${COMPILER_RPATH_FLAG}${PREFIX}/lib/firefox
> ${COMPILER_RPATH_FLAG}${PREFIX}/lib
> 
> --
> Ryo ONODERA // ryo%tetera.org@localhost
> PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3