Re: firefox 61 fails to build on netbsd-7

[David Brownlee <abs%absd.org@localhost>]

On 2 July 2018 at 11:36,  <maya%netbsd.org@localhost> wrote:
> On Mon, Jul 02, 2018 at 11:32:15AM +0100, David Brownlee wrote:
>> On 29 June 2018 at 18:16, David Brownlee <abs%absd.org@localhost> wrote:
>> > On 29 June 2018 at 17:16,  <maya%netbsd.org@localhost> wrote:
>> >> On Fri, Jun 29, 2018 at 11:11:45AM -0400, Greg Troxel wrote:
>> >>>
>> >>> Because it needs gcc 6.1 !!
>> >>>
>> >>
>> >> Deviating from upstream requirement for compiler is a riskier choice for
>> >> freeze.
>> >>
>> >> Documentation to require c++11 is to shove -std=gnu++11 as a flag,
>> >> upstream could be doing it themselves.
>> >>
>> >> This was necesssary because libraries made headers which require C++11 to
>> >> use, and further downstream packages did not adjust flags yet.
>> >
>> > Following up on my mail re
>> > https://bugzilla.mozilla.org/show_bug.cgi?format=default&id=1444274
>> >
>> > On at least NetBSD-8 amd64 firefox appears to build and run fine if
>> > you stub out the gcc version check and force --std=c++14
>> >
>> > Notes:
>> >
>> > - I don't know for certain whether --std=c++14 is needed or if
>> > --std=c++11 would work - I'm trying another build with std=c++11
>> >
>> > - I'm not familiar with the firefox build framework, so for this test
>> > I just hacked in --std=c++14 to the optimise flags, so this is not
>> > ready for commit
>> >
>> > - Even if firefox builds with gcc 5.5 now, its safe to assume it will
>> > start to require 6.1 at some point, so if we put something in for this
>> > it should only be considered a temporary fix for netbsd-8/firefox61
>> >
>> > However, having said that, patch for options.mk and other patch attached
>>
>> OK, so just following up on this.
>>
>> On gcc 5.5 from NetBSD-8:
>> * --std=c++11 is not sufficient to build firefox61
>> * --std=c++14 will build and run fine
>>
>> So that leaves the open question on how to handle firefox61 and NetBSD
>>
>> a) Set GCC_REQD=6.1 on package to reflect current state
>> Will not build on any NetBSD release (or near release) unless all of
>> pkgsrc install has overridden gcc version
>>
>> b) Patch package to build with gcc5.5 and set GCC_REQD=5.5
>> Can now build out of box on netbsd-8, likely to need to revisit in a
>> later release
>>
>> c) Increase min gcc c++ version to 6.1 for NetBSD versions which can build it
>> Can now build out of the box on all appropriate NetBSD versions. Many
>> unhappy people due to needing to build all of gcc6 to install tiny c++
>> packages
>>
>> d) Handle being able to selectively override GCC_REQD for some packages
>> Did we ever get anywhere with this?. Can we reliably do it between
>> *some* versions - eg 5.5 & 6?
>>
>> I have a preference towards b) now, and d) if it becomes possible at
>> some point in the future...
>>
>> David
>
> Yeah we selectively override with GCC_REQD+=6.1 now. ryo committed this.

Ah - sorry missed that.

Woo - happy camper :)

David