Re: why does devel/cmake's Makefile subst's out compiler optimization?

[Chuck Cranor <chuck%ece.cmu.edu@localhost>]

On Sun, Apr 08, 2018 at 08:02:59AM +0200, Thomas Klausner wrote:
> On Sat, Apr 07, 2018 at 05:27:08PM -0400, Chuck Cranor wrote:
> > i tested these with a test pkgsrc build on my laptop and the
> > changes seem to work.
> > do they look ok?
> Yes, they look ok to me.

ok, I just did the commit.


BTW, do you have any suggestion for how to handle the following
issue I discovered with sysutils/cdrtools/Makefile?   I sent it 
to pkgsrc-users but didn't get any suggestions...

chuck



hi-

    in 1.115 of sysutils/cdrtools/Makefile there was a change that
put the compiler in MAKE_ARGS as CCOM:

# Map PKGSRC_COMPILER to CCOM used by cdrtools build system.
.if !empty(PKGSRC_COMPILER:Mclang)
MAKE_FLAGS+=    CCOM=clang
.elif !empty(PKGSRC_COMPILER:Mgcc)
MAKE_FLAGS+=    CCOM=gcc
.else
MAKE_FLAGS+=    CCOM=cc
.endif

this change is causing the configuration step to fail on OS with
clang because it sets CC to "i386-darwin-clang" when it runs 
autoconf (thus the failure, see below).   it looks like it is 
turning "CCOM=clang" into "CC=i386-darwin-clang" somwhere in the 
work/cdrtools-3.01/RULES files.

reverting Makefile to 1.114 "fixes" this, but how is this supposed 
to work?

chuck


=> Bootstrap dependency digest>=20010302: found digest-20160304
===> Skipping vulnerability checks.
WARNING: No /usr/local/pkg.1804/pkgdb/pkg-vulnerabilities file found.
WARNING: To fix run: `/usr/local/pkg.1804/sbin/pkg_admin -K /usr/local/pkg.1804/pkgdb fetch-pkg-vulnerabilities'.
=> Checksum SHA1 OK for cdrtools-3.01.tar.bz2
=> Checksum RMD160 OK for cdrtools-3.01.tar.bz2
=> Checksum SHA512 OK for cdrtools-3.01.tar.bz2
===> Installing dependencies for cdrtools-3.01nb1
=> Tool dependency nbpatch-[0-9]*: found nbpatch-20151107
=> Build dependency cwrappers>=20150314: found cwrappers-20180325
=> Full dependency gettext-lib>=0.18: found gettext-lib-0.19.8.1
===> Overriding tools for cdrtools-3.01nb1
===> Extracting for cdrtools-3.01nb1
===> Patching for cdrtools-3.01nb1
=> Applying pkgsrc patches for cdrtools-3.01nb1
=> Fixing paths.
=> Fixing OSS sound device path.
===> Creating toolchain wrappers for cdrtools-3.01nb1
===> Configuring for cdrtools-3.01nb1
=> Fixing INS_BASE.
cd /usr/local/src/pkgsrc/sysutils/cdrtools/work/cdrtools-3.01/RULES;						 for suffix in netbsd-cc.rul netbsd-gcc.rul; do			 if [ ! -f x86_64-$suffix ]; then			 ln -sf i386-$suffix x86_64-$suffix;	 fi;							 done;								 cd /usr/local/src/pkgsrc/sysutils/cdrtools/work/cdrtools-3.01 && /usr/bin/env INSTALL_INFO= MAKEINFO=/usr/local/src/pkgsrc/sysutils/cdrtools/work/.tools/bin/makeinfo FLEX= BISON= PKG_CONFIG= PKG_CONFIG_LIBDIR=/usr/local/src/pkgsrc/sysutils/cdrtools/work/.buildlink/lib/pkgconfig:/usr/local/src/pkgsrc/sysutils/cdrtools/work/.buildlink/share/pkgconfig PKG_CONFIG_LOG=/usr/local/src/pkgsrc/sysutils/cdrtools/work/.pkg-config.log PKG_CONFIG_PATH= MAKE=make CWRAPPERS_CONFIG_DIR=/usr/local/src/pkgsrc/sysutils/cdrtools/work/.cwrapper/config CC=clang CFLAGS=-O2\ -I/usr/include\ -I/usr/local/pkg.1804/include CPPFLAGS=-I/usr/include\ -I/usr/local/pkg.1804/include CXX=clang++ CXXFLAGS=-O2\ -I/usr/include\ -I/usr/local/pkg.1804/include COMPILER_RPATH_FLAG=-L F77=f77 FC=f77 FFLAGS=-O LANG=C LC_ALL=C LC_COLLATE=C LC_CTYPE=C LC_MESSAGES=C LC_MONETARY=C LC_NUMERIC=C LC_TIME=C LDFLAGS=-liconv\ -L/usr/local/pkg.1804/lib\ -lintl\ -L/usr/lib LINKER_RPATH_FLAG=-L PATH=/usr/local/src/pkgsrc/sysutils/cdrtools/work/.cwrapper/bin:/usr/local/src/pkgsrc/sysutils/cdrtools/work/.buildlink/bin:/usr/local/src/pkgsrc/sysutils/cdrtools/work/.tools/bin:/usr/local/pkg.1804/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/pkg.1804/bin:/usr/local/pkg.1804/sbin:/usr/local/pkg.1804/bin:/opt/X11/bin PREFIX=/usr/local/pkg.1804 MAKELEVEL=0 CONFIG_SITE= PKG_SYSCONFDIR=/usr/local/pkg.1804/etc CXXCPP=clang\ -E HOME=/usr/local/src/pkgsrc/sysutils/cdrtools/work/.home CWRAPPERS_CONFIG_DIR=/usr/local/src/pkgsrc/sysutils/cdrtools/work/.cwrapper/config /usr/bin/gnumake GMAKE_NOWARN=true CCOM=clang config
RULES/rules.top:47: RULES/ldummy.lnk: No such file or directory
RULES/rules1.top:271: incs/Dnull: No such file or directory
RULES/rules1.top:278: incs/Dcc.i386-darwin: No such file or directory
RULES/rules.top:83: RULES/x86_64-darwin-clang.rul: No such file or directory
RULES/rules.cnf:69: incs/i386-darwin-clang/Inull: No such file or directory
RULES/rules.cnf:70: incs/i386-darwin-clang/rules.cnf: No such file or directory
	==> MAKING DIRECTORY "incs/i386-darwin-clang/Inull"
	==> CONFIGURING RULES "incs/i386-darwin-clang/rules.cnf"
creating cache ./config.cache
checking host system type... x86_64-apple-macosx15.6.0
checking if sh is bash... yes
checking if /bin/sh is bash... yes
checking whether sh -ce is broken... no
checking whether /bin/sh -ce is broken... no
checking whether /bin/bosh is a working shell... no
checking whether /opt/schily/bin/bosh is a working shell... no
checking for cc... i386-darwin-clang
checking for gcc... (cached) i386-darwin-clang
checking whether the C compiler (i386-darwin-clang -O2 -I/usr/include -I/usr/local/pkg.1804/include ) works... no
configure: error: installation or configuration problem: C compiler i386-darwin-clang not found.
gnumake: *** [incs/i386-darwin-clang/rules.cnf] Error 1
*** Error code 2

Stop.
bmake[1]: stopped in /usr/local/src/pkgsrc/sysutils/cdrtools
*** Error code 1

Stop.
bmake: stopped in /usr/local/src/pkgsrc/sysutils/cdrtools