emacs25 ignores PKG_OPTIONS.emacs=x11 on OSX

[Chuck Cranor <chuck%ece.cmu.edu@localhost>]

hi-

    On OSX the emacs25 configure script chooses "nextstep" as the
window system unless you specify "--without-ns" ... This causes
it to ignore "PKG_OPTIONS.emacs=x11" like this:

# ls
CVS             Makefile.common PLIST.gnustep   files           patches
DESCR           PLIST           buildlink3.mk   hacks.mk        version.mk
Makefile        PLIST.cocoa     distinfo        options.mk      work
# 
# bmake configure |& egrep 'PKG_OPTIONS.emacs|What window system should Emacs use'
        PKG_OPTIONS.emacs = x11
  What window system should Emacs use?                    nextstep
# 

then it blows up in "bmake install" because it built for "nextstep"
but pkgsrc thinks it has an "x11" config.


    Would it be ok to add a "--without-ns" to options.mk in the x11
section?   that fixes the issue on OSX, and "make configure" on my
netbsd/i386 box doesn't complain about "--without-ns" either.

chuck



Index: options.mk
===================================================================
RCS file: /cvsroot/pkgsrc/editors/emacs25/options.mk,v
retrieving revision 1.3
diff -u -r1.3 options.mk
--- options.mk	27 Apr 2017 13:27:57 -0000	1.3
+++ options.mk	30 Mar 2018 17:42:55 -0000
@@ -74,7 +74,7 @@
 ###
 .if !empty(PKG_OPTIONS:Mx11)
 
-CONFIGURE_ARGS+=	--with-x
+CONFIGURE_ARGS+=	--with-x --without-ns
 CONFIGURE_ARGS+=	--with-xpm
 CONFIGURE_ARGS+=	--with-jpeg
 CONFIGURE_ARGS+=	--with-tiff