Re: Use the newly introduced GIT_ENV instead of tweaking a supposedly internal variable.

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Fri, Nov 13, 2015 at 09:51:19AM +0000, Hauke Fath wrote:
> Module Name:	pkgsrc-wip
> Committed By:	Hauke Fath <hauke%NetBSD.org@localhost>
> Pushed By:	hauke
> Date:		Fri Nov 13 10:51:19 2015 +0100
> Changeset:	57f61335580157ca9eb9ce728dff96f189f7934f
> 
> Modified Files:
> 	git-modes-git/Makefile
> 	gr-fcdproplus-git/Makefile
> 	magit-git/Makefile
> 
> Log Message:
> Use the newly introduced GIT_ENV instead of tweaking a supposedly
> internal variable.

Why is this necessary for these particular three packages, that all
reside on github, and not all the other github packages?

To me this looks like a local setup problem (missing certificates)
that is papered over...
 Thomas


> To see a diff of this commit:
> https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=57f61335580157ca9eb9ce728dff96f189f7934f
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
> 
> diffstat:
>  git-modes-git/Makefile     | 2 +-
>  gr-fcdproplus-git/Makefile | 2 +-
>  magit-git/Makefile         | 4 ++--
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diffs:
> diff --git a/git-modes-git/Makefile b/git-modes-git/Makefile
> index 165bd3f..987705b 100644
> --- a/git-modes-git/Makefile
> +++ b/git-modes-git/Makefile
> @@ -6,6 +6,7 @@ LICENSE=	gnu-gpl-v3
>  GIT_REPOSITORIES=	master
>  GIT_REPO.master=	https://github.com/magit/git-modes.git
>  GIT_MODULE.master=	git-modes
> +GIT_ENV+=		GIT_SSL_NO_VERIFY=true
>  
>  MAINTAINER=	pkgsrc-users%NetBSD.org@localhost
>  HOMEPAGE=	https://github.com/magit/git-modes
> @@ -25,5 +26,4 @@ do-install:
>  
>  .include "../../wip/emacs-current/modules.mk"
>  .include "../../wip/mk/git-package.mk"
> -_GIT_ENV+=		GIT_SSL_NO_VERIFY=true
>  .include "../../mk/bsd.pkg.mk"
> diff --git a/gr-fcdproplus-git/Makefile b/gr-fcdproplus-git/Makefile
> index 6ae5d88..62d34eb 100644
> --- a/gr-fcdproplus-git/Makefile
> +++ b/gr-fcdproplus-git/Makefile
> @@ -11,6 +11,7 @@ LICENSE=		gnu-gpl-v2
>  GIT_REPOSITORIES=	master
>  GIT_REPO.master=	https://github.com/dl1ksv/gr-fcdproplus
>  GIT_MODULE.master=	gr-fcdproplus
> +GIT_ENV+=		GIT_SSL_NO_VERIFY=true
>  
>  USE_LANGUAGES=		c c++
>  USE_TOOLS=		cmake
> @@ -33,7 +34,6 @@ SUBST_MESSAGE.libusb=	Fix for "libusb.h not found"
>  .include	"../../wip/mk/git-package.mk"
>  # you need place after above line for now.
>  _GIT_FLAGS=		# set empty, --depth 1 seems harmfull
> -_GIT_ENV+=		GIT_SSL_NO_VERIFY=true
>  
>  .include	"../../devel/boost-headers/buildlink3.mk"
>  .include	"../../devel/boost-libs/buildlink3.mk"
> diff --git a/magit-git/Makefile b/magit-git/Makefile
> index 54de047..932b3f2 100644
> --- a/magit-git/Makefile
> +++ b/magit-git/Makefile
> @@ -11,6 +11,8 @@ LICENSE=	gnu-gpl-v3
>  GIT_REPOSITORIES=	master
>  GIT_REPO.master=	https://github.com/magit/magit.git
>  GIT_MODULE.master=	magit
> +# for "SSL certificate problem: unable to get local issuer certificate"
> +GIT_ENV+=	GIT_SSL_NO_VERIFY=true
>  
>  WRKSRC=		${WRKDIR}/${PKGBASE}
>  NO_CONFIGURE=	yes
> @@ -41,7 +43,5 @@ post-patch:
>  	(cd ${WRKSRC}; ${GMAKE} VERSION=${PKGVERSION} magit-version.el)
>  
>  .include "../../wip/mk/git-package.mk"
> -# for "SSL certificate problem: unable to get local issuer certificate"
> -_GIT_ENV+=	GIT_SSL_NO_VERIFY=true
>  .include "../../wip/git-modes-git/buildlink3.mk"
>  .include "../../mk/bsd.pkg.mk"
>