Re: Building libfetch and fetch in-tree

[Pierre Pronchery <khorben%defora.org@localhost>]

On 01/10/2013 23:13, Joerg Sonnenberger wrote:
> On Tue, Oct 01, 2013 at 11:09:57PM +0200, Pierre Pronchery wrote:
>> On 01/10/2013 19:26, Joerg Sonnenberger wrote:
>>> On Mon, Sep 30, 2013 at 01:00:50AM +0200, Pierre Pronchery wrote:
>>>> I am attaching a complete diff here anyway; please let me know if/when I
>>>> could commit part or all of these changes.
>>>
>>> This should *not* be committed.
>>
>> Why not? It unbreaks the upstream repository, without breaking anything
>> within pkgsrc (as far as I can see).
> 
> The repository is not broken. It works exactly as it is supposed to.

Ok, let's have a look:

khorben:edgebsd-pkgsrc/net/fetch/files$ git branch
* master
[rigorously the same as pkgsrc's HEAD]
khorben:edgebsd-pkgsrc/net/fetch/files$ ./configure
[...]
khorben:edgebsd-pkgsrc/net/fetch/files$ make
#   compile  files/fetch.o
gcc -O2 -fstack-protector -Wstack-protector   --param ssp-buffer-size=1
 -std=gnu99 -Werror    -DHAVE_CONFIG_H  -c    fetch.c
fetch.c:33:22: fatal error: nbcompat.h: No such file or directory
compilation terminated.
*** Error code 1

Obviously failed.

The same with the patches applied:

khorben:edgebsd-pkgsrc/net/fetch/files$ git checkout khorben-fetch
Switched to branch 'khorben-fetch'
khorben:edgebsd-pkgsrc/net/fetch/files$ ./configure
[...]
edgebsd-pkgsrc/net/fetch/files$ make
#   compile  files/fetch.o
gcc -O2 -fstack-protector -Wstack-protector   --param ssp-buffer-size=1
 -std=gnu99 -Werror    -DHAVE_CONFIG_H  -c    fetch.c
#      link  files/fetch
gcc        -o fetch  fetch.o -lfetch -lfetch -lssl -lcrypto
-Wl,-rpath-link,/lib  -L=/lib
#    format  files/fetch.html1
mandoc -Thtml -Oman=../html%S/%N.html -Ostyle=../style.css
-Oman=../html%S/%N.html -Ostyle=../style.css  fetch.1 > fetch.html1.tmp
&&  mv fetch.html1.tmp fetch.html1
khorben:edgebsd-pkgsrc/net/fetch/files$ ./fetch -?
fetch: unknown option -- ?
usage: fetch [-146AFMPRUadilmnpqrsv] [-N netrc] [-o outputfile]
             [-S bytes] [-B bytes] [-T seconds] [-w seconds]
             [-h host -f file [-c dir] | URL ...]

Works fine.

So now, how does it not improve the situation?

Curious,
-- 
khorben