Re: Building MPlayer without runtime cpu detection

[David Brownlee <abs%NetBSD.org@localhost>]

On Wed, 7 Jan 2009, Sergey Svishchev wrote:

> Good day,
>
> In multimedia/mplayer-share/Makefile.cflags r1.4 abs@ removed the
> .else clause that 'Let "configure" do its thing"'.  This stops MPlayer
> configure script from autodetecting optimization flags -- the script
> only does this if CFLAGS environment variable is empty or unset.
>
> If mplayer-runtime-cpudetection and mplayer-default-cflags options are
> unset, you'd expect to get best available optimization, which currently
> doesn't work.
>
> Proposed fix:
>
> --- multimedia/mplayer-share/Makefile.cflags	8 Feb 2008 10:17:26 -0000 
> 1.5
> +++ multimedia/mplayer-share/Makefile.cflags    7 Jan 2009 14:44:24 -0000
> @@ -21,4 +21,6 @@
> .  else
> CFLAGS+=        -O3 -ffast-math -fomit-frame-pointer
> .  endif
> +.else
> +CFLAGS=                # Let "configure" do its thing.
> .endif

        I rely on the current behaviour - I set my 'ideal' CFLAGS in
        mk.conf and all packaged build with them (I build on a faster
        box than I run so autodetected CFLAGS would be a lose for me).

        I have no objections to a mplayer-compiletime-cpudetection or
        similar option...


--
                David/absolute       -- www.NetBSD.org: No hype required --