Re: CVS commit: pkgsrc/sysutils/hal

[Robert Elz <kre%munnari.OZ.AU@localhost>]

    Date:        Mon,  8 Dec 2008 20:26:13 +0000 (UTC)
    From:        Adam Hoka <ahoka%NetBSD.org@localhost>
    Message-ID:  <20081208202613.6E465175D0%cvs.netbsd.org@localhost>

  | Log Message:
  | Honour PKG_SYSCONFBASE when installing dbus policy.

There are two problems with this this change.

First, according to pkgsrc.txt, you're not supposed to use
PKG_SYSCONFBASE in packages.  I quote:

  * PKG_SYSCONFBASE: The configuration's root directory. Defaults to ${PREFIX}/
    etc although it may be overridden by the user to point to his preferred
    location (e.g., /etc, /etc/pkg, etc.). Packages must not use it directly.

Note the final sentence.  You should have used PKG_SYSCONFDIR instead,
which will (in this case) end up meaning the same thing.

Second, of itself, the change does nothing very useful (I know, I
have tried it) as nothing is passing the sysconfdir town to the hal
makefiles.

Now fixing that is trivial, and just requires

CONFIGURE_ARGS+=        --sysconfdir=${PKG_SYSCONFDIR}

in the pkgsrc Makefile.

Unfortunately, that ends up causing all kinds of other problems,
as hal seems to be utterly confused about the distinction between
a "system configuration file" and a "data file" and ends up
expecting to find all kinds of stuff under PKG_SYSCONFDIR instead
of ...pkg/share/... somewhere where it belongs (if I remember correctly,
it ends up looking in the wrong place for the files installed by
sysutils/hal-info which definitely do not belong under PKG_SYSCONFDIR
(and are not installed there by hal-info), but hal expects to
find inside the directory it is told via the --sysconfdir arg to
configrure.

That's where I stopped looking...

kre