Re: Porting umb(4) from OpenBSD

[Pierre Pronchery <khorben%defora.org@localhost>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

		Hey tech-net@, (Maxime)

On 04/05/2018 13:14, Maxime Villard wrote:
> Le 04/05/2018 à 03:27, Pierre Pronchery a écrit :
>> 
>> On 03/05/2018 09:58, Maxime Villard wrote:
>>> Le 03/05/2018 à 04:46, Pierre Pronchery a écrit :
>>>> You can obtain the fix(es) and follow my changes as I go
>>>> here: 
>>>> https://git.edgebsd.org/gitweb/?p=src.git;a=shortlog;h=refs/heads/k
horben/umb
>>>>
>>>
>>>
>>>> 
int         umb_match(device_t, cfdata_t, void *);
>>> [etc] please make all of that static, global symbols are bad
>> 
>> Done.
> 
> I think it would have been better to use "static" instead of
> "Static", aliases are bad too.

Mmh I reproduced what I saw in cdce(4)... In this case it seems to be
useful when debugging the driver (eg to get more accurate stack traces).
Should we change this everywhere?

>> [...]
>>> sc->sc_resp_buf = kmem_alloc(sc->sc_ctrl_len, M_NOWAIT);
>>> 
>>> that's the wrong flag

Thanks, I fixed that!

I have also fixed a few other issues, now I am a point where:
- - I can set the PIN code, APN, username, password with umbctl(8)
- - the driver connects correctly to the network
- - I can monitor the connectivity with umbctl(8)
- - connectivity information is obtained as expected (IP address, gateway)

I am now stuck at trying to set the local and remote IP addresses on
the umb0 interface. Can anyone help me there?

I have tried in_ifinit(), as seen in sys/net/if_spppsubr.c, but I am
still not able to get it to work properly; is it the right way?

Cheers,
- -- 
khorben
-----BEGIN PGP SIGNATURE-----

iQJHBAEBCAAxFiEEjPEp1wC4bxBrX8svMDjL25iGlwMFAlr4ulMTHGtob3JiZW5A
ZGVmb3JhLm9yZwAKCRAwOMvbmIaXA1q3D/4upQM2fZrDtGtIgHyvNS2h7uNPDXRd
qo0HCO9I5HhI1jyBvldICZm+f7gDnzIiqHYj1BDP+mObm6dPhJMn65/rmmRjp0YG
TJ++3R+TlalCTcD8d+5NUgHW9h10oFcgMrSL3HOv1ulu7eiBzbhnmj7SLpvQ5mGp
ryMEEmczc0Pj0vRG4+xO2dpQPtJQ/JKiBHNQDM1tCaQi0n7XgqVam+/3++f4sJMa
9U5VUza1Lib41cbuQv8mVPAE/a8cEOkOZggjp9YcUnEXBxq6ED4nZ6GQvT1SNziZ
Zw5Gc/cF4qs80PfLQMOAfWQn23UFBcKd0vtu+IgBRXYIJrkHzIaaSJIhM5yiJe2G
qQfghS0hFuSpposC7/dqTM5OC3dd58FD1ledhP92KCPZ5Ihb/KyBi3N/28Lcp/l2
UOXgr5l/h11jiEatbchbXFoRiFId8V89IZUkrUpbFq27VFBMn9diQMdkpr6o6Iu3
+7bX9tj3/ZgYYexq0H4XwibOdljnGjQOWBveth7iF8Q3l6daFdrdDfGObDe14a8/
6OjMYaH2Smnl8PhalpT9a6vTXBHu6IncAtrqBwhV1Hzk2k1GxR8AXGnjf0w+UQX1
6l3S1E9djoS40OTWQ/5x5eUMpMXqjbSCcdQRKjC4IzH2ZJ6JEK8mhQQF6M5drWC4
xebr7b2UDflUzQ==
=Jd76
-----END PGP SIGNATURE-----