tech-net archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: RFC: new ifnet MP-scalable sending interface



Hi joerg@n.o,

On 2016/04/27 17:53, Joerg Sonnenberger wrote:
> On Wed, Apr 27, 2016 at 04:27:56PM +0900, Kengo NAKAHARA wrote:
>> I have considered it a little, so that I use if_transmit member directly
>> because of the clean of caller and ifq_enqueue() implementation. I feel
>> like avoiding extra if-else statement in fast path every time. However,
>> as you point out, it would not be a clear responsibility separation...
>> Hmm, I will implement if_transmit to virtual interfaces such as gif(4).
>> Do you think virtual interfaces should also use ifq_enqueue? If so,
>> I will modify to use ifq_enqueue.
> 
> I think if_transmit is perfect fine.

Thank you for comments. I commit the patch.


Thanks,

-- 
//////////////////////////////////////////////////////////////////////
Internet Initiative Japan Inc.

Device Engineering Section,
IoT Platform Development Department,
Network Division,
Technology Unit

Kengo NAKAHARA <k-nakahara%iij.ad.jp@localhost>


Home | Main Index | Thread Index | Old Index