tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: [PATCH] Fixing soft NFS umount -f, round 1



On Sat, Jun 27, 2015 at 10:33:42AM +0200, Emmanuel Dreyfus wrote:
 > > > 1) In umount(8), we called sync(2) before attempting a forced unmount(2),
 > > >    but sync(2) does not return before data is sent to storage, and 
 > > >    therefore we never had the opportunity to attempt the forced unmount
 > > >    when using -f
 > > 
 > > the sync() is never necessary, you can just remove it.
 > 
 > I committed that non-controversial bit.

...however, with a dead nfs server even sync() should time out and
fail eventually.

-- 
David A. Holland
dholland%netbsd.org@localhost


Home | Main Index | Thread Index | Old Index