tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: sys/dev/isa/fd.c FDUNIT/FDTYPE



> } FDUNIT and FDTYPE are calculated from device minor using the
> } hardcoded DEV/MOD number, as MI DISKUNIT and DISKPART for harddrives.
> } __HAVE_OLD_DISKLABEL was introduced to add magics in MD DISKUINT()
> } and DISKPART() macro to avoid renumbering existing old device minors
> } on MAXPARTITION bump.
> } Current MI MAKEDEV.tmpl treats floppy device minors as harddrives.
> 
>      Again, I don't see your point.  You're talking about a major bug
> in MAKEDEV where it treats floppy drives the same as hard drives.  They
> aren't the same and the letters in the "unit number" don't have the
> same meaning.

If we "fix" kernels to use DISKUNIT() and DISKPART() macro
for FDUNIT() and FDTYPE(), we can bump a number of fd types
to MAXPARTITIONS with no further changes.
Nothing needs to be done by users in that case.

I thought it was acceptable workaround because paying extra costs
against correctness of such obsolete device was worthless and
we had much more important problems on modern devices.

---
Izumi Tsutsui


Home | Main Index | Thread Index | Old Index