Re: Questions regarding acpi_tz(4)

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Sat, Nov 08, 2008 at 06:31:45AM -0800, Paul Goyette wrote:
> 1. In addition to setting the sensor's state, the driver reports state
>    changes via aprint_normal_dev().  There was some discussion a while
>    ago about "chatty" (or "noisy") sensor reports, so I was wondering
>    if we really should report the sensor state both via sysmon_envsys(9)
>    _and_ aprint_normal_dev().  Shouldn't the aprint_normal_dev() calls
>    be removed, or at the very least replaced with aprint_debug_dev() ??

As long as you get a dmesg and console entry for the critical-over case,
I don't care where it gets handled. So envsys would be prefered for
this.

> 2. When the sensor's warning threshold is reached, the drivers sets the
>    state to ENVSYS_SWARNOVER.  But when it reachs the critical level,
>    it sets the state to ENVSYS_SCRITICAL.  It seems to me that this
>    should be ENVSYS_SCRITOVER rather than ENVSYS_SCRITICAL.

Agreed.

Joerg