Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/lib/libcurses



On Sun, Jan 16, 2022 at 10:30:45 +0000, Roland Illig wrote:

> Modified Files:
> 	src/lib/libcurses: addbytes.c ins_wstr.c
> 
> Log Message:
> libcurses: remove unreachable statements

That summary sounds kinda misleading to me.  It's technically true -
the commit removes unreachable *empty* statements - accidentally
doubled semicolons in return foo;; and the like - but it makes it
sound much more ominous by failing to mention that fact.  I would have
skipped a change summarized, e.g., as "g/c duplicate semicolons" or
something like that that actually captured the essense of the change
correctly.  I felt compelled to go and take a look at something
described as "remove unreachable statements".  Please, can you be more
careful in wording those?

-uwe


Home | Main Index | Thread Index | Old Index