Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.bin/make

On Fri, Jan 07, 2022 at 08:04:49PM +0000, Roland Illig wrote:
> Module Name:	src
> Committed By:	rillig
> Date:		Fri Jan  7 20:04:49 UTC 2022
> Modified Files:
> 	src/usr.bin/make: for.c
> Log Message:
> make: use simpler code for handling .for loops

This seems backwards to me. For simpler logic I would expect computing
the var length first and then skipping variables that don't have the
same length, falling back to memcmp otherwise. De facto inlining a
memcmp loop is not an improvement.


Home | Main Index | Thread Index | Old Index