Re: CVS commit: src

[Roland Illig <roland.illig%gmx.de@localhost>]

On 13.02.2021 17:20, Valery Ushakov wrote:
> Thanks for working on this, but a couple of nitpicks:
>
> On Sat, Feb 13, 2021 at 14:30:37 +0000, Roland Illig wrote:
>
> > In sysinst, the installation screen is indented with tabs.  Sysinst uses
> > msgc, which brings its own text layout engine.  This engine does not use
> > addbytes but addch.
> [...]
> > This bug largely went unnoticed because most other applications use
> > addbytes instead, which worked fine all the time.
>
> That doesn't make much sense b/c addbytes is not even a stadnard
> interface.  It's an internal low-level function.

Ah, that explains why there is no manual page for addbytes.  I
double-checked the code, and internally the functions that operate on
plain char call addbytes eventually.

> > It had been introduced somewhere between NetBSD 8.0 and NetBSD 9.0.
>
> As I have pointed out, this was introduced in:
>
> revision 1.44
> date: 2016-11-28 21:25:26 +0300;  author: christos;  state: Exp;  lines: +8 -4;  commitid: MHbzU41X9arGoVvz;
> If we are inserting spaces to account for a tab, move the x position of the
> cursor, otherwise this is a no-op (Carsten Kunze)
>
>
> Unlike the file's content the commit logs are uneditable, so please,
> try to make them accurate.  curses is a huge mess already as it is
> (the standard API as such, not (just) our implementation) and etching
> in stone potentially misleading information doesn't help...

Thanks for the advice, I will do that.