Re: CVS commit: src

[Roland Illig <roland.illig%gmx.de@localhost>]

On 13.02.2021 20:00, Valery Ushakov wrote:
> On Sat, Feb 13, 2021 at 14:30:37 +0000, Roland Illig wrote:
>
> > Libcurses can be built in 2 modes: with wide character support or
> > without (-DDISABLE_WCHAR).  The test suite only covers the variant with
> > wide characters.  The single-byte variant has to be tested manually.
> > Running sysinst with the single-byte libcurses produces the correct
> > layout.
>
> Also, wide char support extends the original curses api, so the test
> suite that covers the old api plus the new api obviously covers the
> old api (though I don't think the test suite detects if the curses it
> tests actually has wide char support, so it might fail to run, but
> that's a different problem).

That's exactly what I wanted to say:  The libcurses test suite does not
detect whether libcurses supports wchar_t.  It just fails to link if
libcurses does not support the wchar_t API.

What I meant is that there are some #ifdef HAVE_WCHAR_T ... #else ...
#endif.  The #else part cannot be covered by the current test suite.  So
the API may be covered, but the implementation isn't.  Therefore the
manual test.